Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove aria-haspopup from dropdowns #526

Merged
merged 1 commit into from
Oct 31, 2021
Merged

Conversation

IanDelMar
Copy link
Collaborator

aria-haspopup="true" is really intended to signal that an ARIA menu will be opened on activation. as a result, some assistive technologies will announce controls with aria-haspopup="true" as a menu or menu item (e.g. JAWS and NVDA). In addition, aria-haspopup seems to trigger a bug in Edge/Narrator where the aria-expanded state is not correctly announced at the moment when aria-haspopup is present. This now makes the dropdown button more like a generic disclosure widget control - see also https://www.w3.org/TR/wai-aria-practices-1.2/examples/disclosure/disclosure-navigation.html01

See twbs/bootstrap#33624 (comment)

Changes proposed in this Pull Request:

  • Removes aria-haspopup from dropdowns

Proposed changelog entry for your changes:

Remove aria-haspopup from dropdowns

Copy link
Member

@pattonwebz pattonwebz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Nice improvement :)

@pattonwebz pattonwebz merged commit 044edfc into master Oct 31, 2021
@IanDelMar IanDelMar deleted the IanDelMar/aria-haspopup branch November 7, 2021 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants