Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo for $parent_instance param in RecursiveDataStructureTraverser constructor #422

Merged
merged 2 commits into from
Sep 8, 2023
Merged

Fix typo for $parent_instance param in RecursiveDataStructureTraverser constructor #422

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c11bf4d
Fix typo for `$parent_instance` param in `RecursiveDataStructureTrave…
petitphp Sep 7, 2023
1c2e9fe
Apply suggestion and reformat
danielbachhuber Sep 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/WP_CLI/Entity/RecursiveDataStructureTraverser.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ class RecursiveDataStructureTraverser {
*
* @param mixed $data The data to read/manipulate by reference.
* @param string|int $key The key/property the data belongs to.
* @param static $parent
* @param static $parent_instance
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's fix the docblock fully while we're at it.

Suggested change
* @param static $parent_instance
* @param static|null $parent_instance The parent instance of the traverser.

Also, could you adapt the alignment in the docblock? I cannot do that properly via a suggestion...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated in 1c2e9fe

*/
public function __construct( &$data, $key = null, $parent_instance = null ) {
$this->data =& $data;
Expand Down