wp scaffold and WPCS

[sandrodz]

Files generated by wp scaffold command are not WordPress coding standard compliant!

For example cpt generated:

wp-cli/wp-cli#4589

[gitlost]

Close via #110

[gitlost]

Oops, maybe the other files apart from CPT aren't compliant?

Edit: no there're not - taxonomy for one.

Edit2: Taxonomy fixed now via #112, need to check if there's others...

[gziolo]

@schlessera, @danielbachhuber - is there any Behat logic that would run linters on generated files? That would be great to ensure we scaffold files that are WordPress compliant.

[schlessera]

@gziolo No, but that would be a good addition. I'll create an issue for that.

[gziolo]

Awesome, thanks 🙇

[thrijith]

to keep track what else needs work

• wp scaffold _s
• wp scaffold block -- marking as complete ( i couldn't find any errors )
• wp scaffold child-theme
• wp scaffold plugin
• wp scaffold plugin-tests
• wp scaffold post-type
• wp scaffold taxonomy
• wp scaffold theme-tests

@gitlost @schlessera @gziolo I am checking commands I did that were merged

@gziolo you fixed scaffold block right?

[gitlost]

Good idea @thrijith !

[gitlost]

Going to remove this from the 1.1.2 milestone as incomplete at this late stage...

[gziolo]

@gziolo you fixed scaffold block right?

Yes, I fixed using Gutenberg's configuration. For PHP, it should be the same as core uses. JS part follows Eslint setup, but I hope it is similar to what JSHint promotes.

[NicktheGeek]

Looks like plugin and plugin-tests are mostly good to go. I did find an error generated on bootstrap.php. It is a false positive so I added a PR that uses a wpcs exclusion on the line to suppress the error.

[ernilambar]

Command wp scaffold post-type movie --label=Movie --theme=sample-theme

I used rules from the file we are distributing in scaffold - https://github.com/wp-cli/scaffold-command/blob/main/templates/.phpcs.xml.dist

Is it worth revisiting our scaffold snippets as in 6 years there has been lots of changes in the sniffer?

CC @wp-cli/committers

[swissspidy]

Seems reasonable to revisit this & implement some tests to ensure that the scaffolded code always passes PHPCS.