Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release v0.2.0 code cleanup #107

Merged
merged 2 commits into from
Jul 11, 2019
Merged

Release v0.2.0 code cleanup #107

merged 2 commits into from
Jul 11, 2019

Conversation

kidunot89
Copy link
Member

@kidunot89 kidunot89 commented Jul 11, 2019 •
edited
Loading

Your checklist for this pull request

Thanks for sending a pull request! Please make sure you click the link above to view the contribution guidelines, then fill out the blanks below.

🚨Please review the guidelines for contributing to this repository.

  • Make sure you are making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Make sure you are requesting to pull request from a topic/feature/bugfix branch (right side). Don't pull request from your master!

What does this implement/fix? Explain your changes.

Removes unnecessary code and restructures some classes.

  • Rename class Actions to Type_Registry.
  • Rename class Filters to Core_Schema_Filters.
  • Move QL_Session_Handler initializion into WooCommerce_Filters class.
  • Remove unnecessary use statements.

Does this close any currently open issues?

…

Any relevant logs, error output, GraphiQL screenshots, etc?

(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)

Any other comments?

…

Where has this been tested?

Operating System: Ubuntu 18.04

WordPress Version: 5.2

@kidunot89 kidunot89 added enhancement New feature or request bugfix Implements bugfix labels Jul 11, 2019
@kidunot89 kidunot89 self-assigned this Jul 11, 2019
@kidunot89 kidunot89 mentioned this pull request Jul 11, 2019
Merged
18 tasks
@kidunot89 kidunot89 changed the title "Actions" and "Filters" classes renamed and refactored. Release v0.2.0 code cleanup Jul 11, 2019
@kidunot89 kidunot89 merged commit ead3970 into wp-graphql:release-v0.2.0 Jul 11, 2019
@kidunot89 kidunot89 deleted the release-v0.2.0-cleanup branch July 11, 2019 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonbahl jasonbahl Awaiting requested review from jasonbahl

@renatonascalves renatonascalves Awaiting requested review from renatonascalves

Assignees

@kidunot89 kidunot89

Labels
bugfix Implements bugfix enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kidunot89