Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"format" arg added to Product description fields #139

Merged

Conversation

kidunot89
Copy link
Member

…cription".

Your checklist for this pull request

Thanks for sending a pull request! Please make sure you click the link above to view the contribution guidelines, then fill out the blanks below.

🚨Please review the guidelines for contributing to this repository.

  • Make sure you are making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Make sure you are requesting to pull request from a topic/feature/bugfix branch (right side). Don't pull request from your master!

What does this implement/fix? Explain your changes.

Adds format argument to description fields. It functions identically to WPGraphQL's CPT content fields. Users must have the capability for editing products in order to retrieve the raw descriptions straight from the database, same as CPT-based types.

Example Usage

query ( $id: ID!, $format: PostObjectFieldFormatEnum ) {
	product(id: $id) {
		description(format: $format)
		shortDescription(format: $format)
	}
}

PostObjectFieldFormatEnum is an enumeration define in WPGraphQL core, possible values are

  • RAW
  • RENDERED

Does this close any currently open issues?

Any relevant logs, error output, GraphiQL screenshots, etc?

(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)

Any other comments?

Where has this been tested?

Operating System: Ubuntu 18.04

WordPress Version: 5.2

@kidunot89 kidunot89 added the enhancement New feature or request label Sep 3, 2019
@kidunot89 kidunot89 self-assigned this Sep 3, 2019
@kidunot89 kidunot89 merged commit 7288d89 into wp-graphql:develop Sep 3, 2019
@kidunot89 kidunot89 deleted the feature/product-description-filters branch September 3, 2019 20:21
@kidunot89 kidunot89 added this to the v0.2.2 milestone Sep 29, 2019
@kidunot89 kidunot89 mentioned this pull request Oct 24, 2019
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant