Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape hatch added on non-GraphQL requests. #146

Merged
merged 3 commits into from
Oct 23, 2019

Conversation

kidunot89
Copy link
Member

@kidunot89 kidunot89 commented Sep 30, 2019

Your checklist for this pull request

Thanks for sending a pull request! Please make sure you click the link above to view the contribution guidelines, then fill out the blanks below.

🚨Please review the guidelines for contributing to this repository.

  • x] Make sure you are making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Make sure you are requesting to pull request from a topic/feature/bugfix branch (right side). Don't pull request from your master!

What does this implement/fix? Explain your changes.

Adds escape hatch that prevents QL_Session_Handler from being used on any request not made to the GraphQL endpoint, (by default its /graphql).

This includes query made uses the GET method i.e. /graphql?query={...}.

The QL_Session_Handler is designed to only update and send a response header after specific mutations that make changes to the session data like addToCart.

TODO

  • Configure codeception to properly merge code coverage results between suites.

Does this close any currently open issues?

#143

Any relevant logs, error output, GraphiQL screenshots, etc?

(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)

Any other comments?

Where has this been tested?

Operating System: Ubuntu 18.04

WordPress Version: 5.2.3

@kidunot89 kidunot89 added the work in progress Solution development in progress label Oct 3, 2019
@kidunot89 kidunot89 merged commit adf8b2e into wp-graphql:develop Oct 23, 2019
@kidunot89 kidunot89 deleted the bugfix/cart-session-init branch October 23, 2019 23:23
@kidunot89 kidunot89 mentioned this pull request Oct 24, 2019
6 tasks
@kidunot89 kidunot89 removed the work in progress Solution development in progress label Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Implements bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant