Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ProductUnion interface added #797

Merged
merged 2 commits into from
Sep 11, 2023

Conversation

kidunot89
Copy link
Member

Your checklist for this pull request

Thanks for sending a pull request! Please make sure you click the link above to view the contribution guidelines, then fill out the blanks below.

🚨Please review the guidelines for contributing to this repository.

  • Make sure you are making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Make sure you are requesting to pull request from a topic/feature/bugfix/devops branch (right side). Don't pull request from your master!
  • Have you ensured/updated that CLI tests to extend coverage to any new logic. Learn how to modify the tests here.

What does this implement/fix? Explain your changes.

  • ProductVariation no longer inheriting in the Product interface
  • ProductUnion interface added. It's inherited by all Product types and ProductVariation type.
  • Most common product connections are now resolving to the ProductUnion type.
  • graphql_map_input_fields_to_wp_query hook added to Product_Connection_Resolver class. Resolves Problem with offset pagination and polylangs language filter parameter. #794

Does this close any currently open issues?

Any relevant logs, error output, GraphiQL screenshots, etc?

(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)

Any other comments?

Where has this been tested?

  • WooGraphQL Version:
  • WPGraphQL Version:
  • WordPress Version:
  • WooCommerce Version:

@kidunot89 kidunot89 added breaking change Solution will break some older solutions bugfix Implements bugfix labels Sep 11, 2023
@kidunot89 kidunot89 force-pushed the fix/product-union-added branch from e0c2e16 to bc6d28b Compare September 11, 2023 21:21
@kidunot89 kidunot89 merged commit 81502f9 into wp-graphql:develop Sep 11, 2023
14 checks passed
@kidunot89 kidunot89 deleted the fix/product-union-added branch September 11, 2023 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Solution will break some older solutions bugfix Implements bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem with offset pagination and polylangs language filter parameter.
1 participant