Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump deps to meet actual requirements and lint for WPCS 3.0 #816

Merged
merged 11 commits into from
Nov 30, 2023

Conversation

justlevine
Copy link
Contributor

Your checklist for this pull request

Thanks for sending a pull request! Please make sure you click the link above to view the contribution guidelines, then fill out the blanks below.

🚨Please review the guidelines for contributing to this repository.

  • Make sure you are making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Make sure you are requesting to pull request from a topic/feature/bugfix/devops branch (right side). Don't pull request from your master!
  • Have you ensured/updated that CLI tests to extend coverage to any new logic. Learn how to modify the tests here.

What does this implement/fix? Explain your changes.

This PR bumps the minimum WordPress (6.1) and minimum PHP (7.3) versions to match the upstream requirements ( from WooCommerce 7.9.0 ).

Additionally, the PHPCS ruleset has been updated to WPCS 3.0 (since older versions arent compatible with PHP 8.0+) and the resulting smells either remediated (when it wouldnt be a breaking change to do so) or allowlisted.

No actual code functionality has been changed

Does this close any currently open issues?

Any relevant logs, error output, GraphiQL screenshots, etc?

(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)

Any other comments?

Where has this been tested?

  • WooGraphQL Version: develop
  • WPGraphQL Version: 1.18.0
  • **WordPress Version: 6.3.2
  • **WooCommerce Version: 7.9.0, 8.2.1

@kidunot89 kidunot89 self-requested a review November 30, 2023 13:39
@kidunot89 kidunot89 merged commit e962366 into wp-graphql:develop Nov 30, 2023
14 checks passed
@justlevine justlevine deleted the chore/bump-min-and-cs branch November 30, 2023 14:26
@kidunot89 kidunot89 added the dev-ops PR resolves an issue or implements a feature related to the development process label Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev-ops PR resolves an issue or implements a feature related to the development process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants