Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Potential Infinite loop caused by nested pre_get_posts hooks patched #853

Merged

Conversation

kidunot89
Copy link
Member

Your checklist for this pull request

Thanks for sending a pull request! Please make sure you click the link above to view the contribution guidelines, then fill out the blanks below.

🚨Please review the guidelines for contributing to this repository.

  • Make sure you are making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Make sure you are requesting to pull request from a topic/feature/bugfix/devops branch (right side). Don't pull request from your master!
  • Have you ensured/updated that CLI tests to extend coverage to any new logic. Learn how to modify the tests here.

What does this implement/fix? Explain your changes.

  • Adds remove_filter at the top of Protected_Router::resolve_request() to avoid any possible recursive triggers of the hook resulting in an infinite loop

Does this close any currently open issues?

Resolves #846

Any relevant logs, error output, GraphiQL screenshots, etc?

(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)

Any other comments?

Where has this been tested?

  • WooGraphQL Version:
  • WPGraphQL Version:
  • WordPress Version:
  • WooCommerce Version:

@kidunot89 kidunot89 added the bugfix Implements bugfix label May 8, 2024
@kidunot89 kidunot89 requested review from jasonbahl and justlevine May 8, 2024 08:49
@kidunot89 kidunot89 self-assigned this May 8, 2024
@kidunot89 kidunot89 force-pushed the fix/protected-router-infinite-loop-fix branch from 496d49b to 4449931 Compare May 17, 2024 01:29
@kidunot89 kidunot89 merged commit 539f514 into wp-graphql:develop May 17, 2024
14 checks passed
@kidunot89 kidunot89 deleted the fix/protected-router-infinite-loop-fix branch May 17, 2024 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Implements bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

process_auth_request causes infinite loop with Woocommerce Memberships plugin when redirecting to checkout
1 participant