-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ssr not always working #1939
Conversation
🦋 Changeset detectedLatest commit: e079433 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
📦 Next.js Bundle Analysis for @faustwp/getting-started-exampleThis analysis was generated by the Next.js Bundle Analysis action. 🤖 🎉 Global Bundle Size Decreased
DetailsThe global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster. Any third party scripts you have added directly to your app using the If you want further insight into what is behind the changes, give @next/bundle-analyzer a try! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
This fixes a bug where the
WordPressTemplate
component would returnnull
on the server whenisPreview
was null.Related Issue(s):
fixes #1813
Testing
I tested following the steps outlined in #1813 on the reproduction mentioned in the issue.
I also was able to reproduce the issue on acf.wpgraphql.com (codebase here: https://github.com/wp-graphql/acf.wpgraphql.com) and was able to confirm that the issue is resolved for acf.wpgraphql.com with this fix in place.
Screenshots
Reproduction Site from #1813 - Before
With JavaScript disabled, the page is blank
Reproduction Site from #1813 - After
Content is rendered even with JavaScript disabled
acf.wpgraphql.com - Before
With JavaScript disabled, the page is blank
acf.wpgraphql.com - After
Content is rendered even with JavaScript disabled