fix: make get_block_attribute_fields() $prefix param non-nullable (#…

…219)
wpengine · Apr 4, 2024 · 7bf6bcb · 7bf6bcb
1 parent bc0de59
commit 7bf6bcb
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 8 deletions.
diff --git a/.changeset/great-pans-poke.md b/.changeset/great-pans-poke.md
@@ -0,0 +1,5 @@
+---
+"@wpengine/wp-graphql-content-blocks": patch
+---
+
+fix: Change Block:get_block_attribute_fields()`$prefix parameter be an optional`string`.
diff --git a/includes/Blocks/Block.php b/includes/Blocks/Block.php
@@ -185,10 +185,10 @@ private function get_attribute_type( $name, $attribute, $prefix ) {
 	/**
 	 * Gets the WPGraphQL field registration config for the block attributes.
 	 *
-	 * @param ?array      $block_attributes The block attributes.
-	 * @param string|null $prefix The current prefix string to use for the get_query_type
+	 * @param ?array $block_attributes The block attributes.
+	 * @param string $prefix The current prefix string to use for the get_query_type
 	 */
-	private function get_block_attribute_fields( ?array $block_attributes, $prefix = '' ): array {
+	private function get_block_attribute_fields( ?array $block_attributes, string $prefix = '' ): array {
 		$fields = [];
 
 		// Bail early if no attributes are defined.

diff --git a/phpstan-baseline.neon b/phpstan-baseline.neon
@@ -20,11 +20,6 @@ parameters:
 			count: 1
 			path: includes/Blocks/Block.php
 
-		-
-			message: "#^Parameter \\#3 \\$prefix of method WPGraphQL\\\\ContentBlocks\\\\Blocks\\\\Block\\:\\:get_attribute_type\\(\\) expects string, string\\|null given\\.$#"
-			count: 1
-			path: includes/Blocks/Block.php
-
 		-
 			message: "#^Call to an undefined method DiDom\\\\Element\\|DOMElement\\:\\:html\\(\\)\\.$#"
 			count: 1