Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add filter to get_block_context_interfaces() #148

Merged

Conversation

jasonbahl
Copy link
Contributor

This adds a filter to the get_block_context_interfaces method, allowing 3rd party code to opt-out of ${PostTypeName}EditorBlock Interface(s) from being implemented to a block.

closes #147

@jasonbahl jasonbahl requested a review from a team as a code owner August 17, 2023 21:37
@jasonbahl jasonbahl self-assigned this Aug 17, 2023
@changeset-bot
Copy link

changeset-bot bot commented Aug 17, 2023

⚠️ No Changeset found

Latest commit: 3650fa7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@theodesp
Copy link
Member

Hey @jasonbahl Is this for performance reasons? I will try to performate this to check the difference

@jasonbahl
Copy link
Contributor Author

@theodesp no, it's not performance related (although there might be performance impacts of interfaces being over-applied).

I tried to explain the problem in #147.

Let me know if you need more clarity after reading that issue.

- update Docblock for filter
mindctrl
mindctrl previously approved these changes Sep 1, 2023
@mindctrl mindctrl merged commit a118662 into main Sep 1, 2023
7 checks passed
@mindctrl mindctrl deleted the feat/#147-allow-block-context-interfaces-to-be-filtered branch September 1, 2023 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow get_block_context_interfaces to be filtered
4 participants