chore: implement stricter PHPStan ruleset and fix new errors. #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b6b8af1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
justlevine
force-pushed
the
chore/stricter-phpstan-rules
branch
from
4b1350d to
b6b8af1
Compare
mindctrl
approved these changes
Mar 27, 2024
|
(rebased on main) |
mindctrl
approved these changes
Mar 27, 2024
|
Thank you @justlevine! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR updates
phpstan.neon.distfor stricter detection of errors, and addresses the newly-detected errors. More specifically:DiDom\Document::loadHtml()have been updated to use the correct casing. (Previously these were calls toloadHTML())nullfrom the return DocType of DOMHelpers::getElementsFromHTML() and DOMHelpers::parseHTML(), since those methods only turn a typestringIRL. Note: The method signature was not changed.Warning
This PR requires #210 , which should be merged first (to avoid conflicts with the PHPStan baseline). The relevant commits for this PR are:- b7109ac- 4308eaf- 52099c2