Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merl-862] Add support for Classic Blocks #59

Merged
merged 3 commits into from
May 2, 2023
Merged

[Merl-862] Add support for Classic Blocks #59

merged 3 commits into from
May 2, 2023

Conversation

theodesp
Copy link
Member

@theodesp theodesp commented Apr 27, 2023

Description

This PR adds support for querying Classic Blocks. Since those blocks are not stored in the database with a proper name we assign them a name now and resolve them as CoreFreeForm returning the contents of the innerHTML as long as the contents are not empty.

Screenshots

Screenshot 2023-04-27 at 13 07 58

Testing

  1. Create a Classic block in a post
  2. Query for the content attribute in editor blocks.
  3. Block should resolve as CoreFreeForm as plain HTML.

@changeset-bot
Copy link

changeset-bot bot commented Apr 27, 2023

⚠️ No Changeset found

Latest commit: f19edcd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@theodesp theodesp marked this pull request as ready for review April 27, 2023 15:34
@theodesp theodesp requested a review from a team as a code owner April 27, 2023 15:34
Copy link
Member

@josephfusco josephfusco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants