Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UR-100 Dev - Hooks for custom advance setting #373

Merged
merged 3 commits into from
Jan 6, 2022
Merged

UR-100 Dev - Hooks for custom advance setting #373

merged 3 commits into from
Jan 6, 2022

Conversation

dipuchaudhary
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

Query string allows you to append information with a given URL. You just have to append the parameter and it automatically populates the related field. This PR will allow users to pass multiple variables as a parameter with value and use a single form of varieties of events of creation.

How to test the changes in this Pull Request:

  1. Navigate to the Form Builder.
  2. Select a particular field and navigate to field options.
  3. Go to the Advanced section and make allow fields to be dynamically populated as yes. and give the parameter name for that field.
  4. Create any post or page with extra parameters as field values like param1=value1&param2=value2.
  5. In this way, passing values to various pages or posts as a parameter for the same form can be used.

Types of changes:

  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (modification of the currently available functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully ran tests with your changes locally?
  • Have you updated the documentation accordingly?

Changelog entry

Hooks for custom advance setting.

@dipuchaudhary dipuchaudhary self-assigned this Dec 2, 2021
iamprazol
iamprazol approved these changes Dec 29, 2021
View reviewed changes
Copy link
Member

@iamprazol iamprazol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !! 👍

lekhnath005
lekhnath005 approved these changes Jan 5, 2022
View reviewed changes
Copy link
Contributor

@lekhnath005 lekhnath005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!

Sanjuacharya
Sanjuacharya approved these changes Jan 5, 2022
View reviewed changes
Copy link

@Sanjuacharya Sanjuacharya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@iamprazol iamprazol merged commit 38e3abf into develop Jan 6, 2022
@iamprazol iamprazol deleted the dev/hooks-for-custom-advance-setting branch January 6, 2022 03:14
iamprazol added a commit that referenced this pull request Jan 7, 2022
@iamprazol
Version bump to 2.1.2
ffd7c14 
Squashed commit of the following:

commit 008fd4f
Author: Lekhnath Pandey <lekhnath005@gmail.com>
Date:   Thu Jan 6 13:50:51 2022 +0545

    Fix - Escaping issue in deactivation notice

commit ecf5093
Author: Prajjwal Poudel <85762481+iamprazol@users.noreply.github.com>
Date:   Thu Jan 6 13:29:28 2022 +0545

    UR-91 Enhance - Extension page design and addons installation. (#382)

    * Tweak - Extension installation from addons page support

    * Tweak - Extension page design change

    * Tweak - PRO install method

    * Tweak - Missing images added

    * Tweak - Optimized images added

    * Merge branch 'develop' into enhance/extension-install

    * Tweak - Refresh addons transient for once

commit edc6e7a
Author: Prajjwal Poudel <85762481+iamprazol@users.noreply.github.com>
Date:   Thu Jan 6 09:00:29 2022 +0545

    Fix - Resend verification not working when ajax login is enabled (#383)

commit a34fbdd
Author: Prajjwal Poudel <85762481+iamprazol@users.noreply.github.com>
Date:   Thu Jan 6 09:00:10 2022 +0545

    UR-169 Enhance - Size limit on profile picture field in edit profile page (#376)

    * Tweak - Size limit on profile picture in edit profile

    * Tweak - Max upload size form builder validation

    Co-authored-by: Lekhnath Pandey <lekhnath005@gmail.com>

commit 38e3abf
Author: Dipu chaudhary <34309829+dipuchaudhary@users.noreply.github.com>
Date:   Thu Jan 6 08:59:00 2022 +0545

    UR-100 Dev - Hooks for custom advance setting (#373)

    * Add hooks for custom settings in advance setting of form builder

    * Dev - Filter parameter reordered

    * Tweak - Prepopulate field made dynamic

    Co-authored-by: Prajjwal Poudel <iamprazol@gmail.com>
iamprazol added a commit that referenced this pull request Jan 7, 2022
@iamprazol
Version bump to 2.1.2
a03883d 
Squashed commit of the following:

commit 008fd4f
Author: Lekhnath Pandey <lekhnath005@gmail.com>
Date:   Thu Jan 6 13:50:51 2022 +0545

    Fix - Escaping issue in deactivation notice

commit ecf5093
Author: Prajjwal Poudel <85762481+iamprazol@users.noreply.github.com>
Date:   Thu Jan 6 13:29:28 2022 +0545

    UR-91 Enhance - Extension page design and addons installation. (#382)

    * Tweak - Extension installation from addons page support

    * Tweak - Extension page design change

    * Tweak - PRO install method

    * Tweak - Missing images added

    * Tweak - Optimized images added

    * Merge branch 'develop' into enhance/extension-install

    * Tweak - Refresh addons transient for once

commit edc6e7a
Author: Prajjwal Poudel <85762481+iamprazol@users.noreply.github.com>
Date:   Thu Jan 6 09:00:29 2022 +0545

    Fix - Resend verification not working when ajax login is enabled (#383)

commit a34fbdd
Author: Prajjwal Poudel <85762481+iamprazol@users.noreply.github.com>
Date:   Thu Jan 6 09:00:10 2022 +0545

    UR-169 Enhance - Size limit on profile picture field in edit profile page (#376)

    * Tweak - Size limit on profile picture in edit profile

    * Tweak - Max upload size form builder validation

    Co-authored-by: Lekhnath Pandey <lekhnath005@gmail.com>

commit 38e3abf
Author: Dipu chaudhary <34309829+dipuchaudhary@users.noreply.github.com>
Date:   Thu Jan 6 08:59:00 2022 +0545

    UR-100 Dev - Hooks for custom advance setting (#373)

    * Add hooks for custom settings in advance setting of form builder

    * Dev - Filter parameter reordered

    * Tweak - Prepopulate field made dynamic

    Co-authored-by: Prajjwal Poudel <iamprazol@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sanjuacharya Sanjuacharya Sanjuacharya approved these changes

@lekhnath005 lekhnath005 lekhnath005 approved these changes

@iamprazol iamprazol iamprazol approved these changes

Assignees

@dipuchaudhary dipuchaudhary

Labels
Approved Feature Request Merged Tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dipuchaudhary @Sanjuacharya @lekhnath005 @iamprazol