Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev -Hooks for save btn in profile details #386

Merged
merged 4 commits into from
Jan 25, 2022
Merged

Dev -Hooks for save btn in profile details #386

merged 4 commits into from
Jan 25, 2022

Conversation

dipuchaudhary
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

Previously we do not have hooks for changing the name of the save button and profile details heading in the edit profile. This PR will introduce a hook for both.

How to test the changes in this Pull Request:

  1. Add filter named user_registation_profile_detail_title and user_registration_profile_update_btn in the current active themes of your site and verify if it's working or not.

Types of changes:

  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (modification of the currently available functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully ran tests with your changes locally?
  • Have you updated the documentation accordingly?

Changelog entry

Dev -Hooks for save btn in profile details.

@dipuchaudhary dipuchaudhary self-assigned this Jan 24, 2022
iamprazol
iamprazol approved these changes Jan 25, 2022
View reviewed changes
Copy link
Member

@iamprazol iamprazol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !! 👍

lekhnath005
lekhnath005 approved these changes Jan 25, 2022
View reviewed changes
Copy link
Contributor

@lekhnath005 lekhnath005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!

@iamprazol iamprazol merged commit 7628f1a into develop Jan 25, 2022
@iamprazol iamprazol deleted the dev/hooks-for-save-btn-in-profile-details branch January 25, 2022 14:35
lekhnath005 pushed a commit that referenced this pull request Jan 26, 2022
@lekhnathpandey
Version bump to 2.1.3
564cd14 
Squashed with following commits:
commit d5e28f7 (HEAD -> develop, origin/develop)
Author: Lekhnath Pandey <46083608+lekhnath005@users.noreply.github.com>
Date:   Wed Jan 26 10:26:27 2022 +0545

    UR-107 Feature - Combine two login options (#375)

    * Feature - Introducing admin approval after email coonfirmation login option

    * Fix - Number field form builder validation issue

    * Fix - Change user status from admin side

    * Tweak - Change in await message content

commit 7628f1a
Author: Dipu chaudhary <34309829+dipuchaudhary@users.noreply.github.com>
Date:   Tue Jan 25 20:20:01 2022 +0545

    Dev -Hooks for save btn in profile details (#386)

    * Dev - Hooks for save button label in profile details

    * Added filter hooks for profile details title

    * Fix - Escaping missing in filter

    Co-authored-by: Prajjwal Poudel <iamprazol@gmail.com>

commit dcaebb7
Author: Prajjwal Poudel <85762481+iamprazol@users.noreply.github.com>
Date:   Tue Jan 25 20:15:46 2022 +0545

    UR-70 Fix - Cannot unhide labels (#388)

    * Fix - Cannot unhide labels

    * Fix - Selection of hide label

commit a1126f6
Author: Lekhnath Pandey <46083608+lekhnath005@users.noreply.github.com>
Date:   Tue Jan 25 20:15:09 2022 +0545

    Fix - Security Issue (#387)

commit 9634e9b
Author: Prajjwal Poudel <85762481+iamprazol@users.noreply.github.com>
Date:   Tue Jan 25 20:14:03 2022 +0545

    UR-205 Fix - Profile picture remove, update and save on the edit profile page (#385)

    * Fix - Profile picture not being removed on edit profile ajax

    * Fix - Profile picture upload on edit profile

    * Fix - Profile picture size issue in edit profile

    * Dev - Conditional logic in profile picture

commit cbe2fde
Author: Dipu chaudhary <34309829+dipuchaudhary@users.noreply.github.com>
Date:   Tue Jan 25 20:13:23 2022 +0545

    UR-192 Fix - File upload data not updated in profile details changed email (#384)

    * Fix - File upload url not updated to admin email while updating profile details

    * Fix - All file updated when multiple file uploaded

commit 50af2c8
Author: Prajjwal Poudel <iamprazol@gmail.com>
Date:   Mon Jan 17 12:59:42 2022 +0545

    Fix - Escaping in checkbox and radion button
lekhnath005 pushed a commit that referenced this pull request Jan 27, 2022
@lekhnathpandey
Version bump to 2.1.3
0282601 
Squashed with following commits:
commit d5e28f7 (HEAD -> develop, origin/develop)
Author: Lekhnath Pandey <46083608+lekhnath005@users.noreply.github.com>
Date:   Wed Jan 26 10:26:27 2022 +0545

    UR-107 Feature - Combine two login options (#375)

    * Feature - Introducing admin approval after email coonfirmation login option

    * Fix - Number field form builder validation issue

    * Fix - Change user status from admin side

    * Tweak - Change in await message content

commit 7628f1a
Author: Dipu chaudhary <34309829+dipuchaudhary@users.noreply.github.com>
Date:   Tue Jan 25 20:20:01 2022 +0545

    Dev -Hooks for save btn in profile details (#386)

    * Dev - Hooks for save button label in profile details

    * Added filter hooks for profile details title

    * Fix - Escaping missing in filter

    Co-authored-by: Prajjwal Poudel <iamprazol@gmail.com>

commit dcaebb7
Author: Prajjwal Poudel <85762481+iamprazol@users.noreply.github.com>
Date:   Tue Jan 25 20:15:46 2022 +0545

    UR-70 Fix - Cannot unhide labels (#388)

    * Fix - Cannot unhide labels

    * Fix - Selection of hide label

commit a1126f6
Author: Lekhnath Pandey <46083608+lekhnath005@users.noreply.github.com>
Date:   Tue Jan 25 20:15:09 2022 +0545

    Fix - Security Issue (#387)

commit 9634e9b
Author: Prajjwal Poudel <85762481+iamprazol@users.noreply.github.com>
Date:   Tue Jan 25 20:14:03 2022 +0545

    UR-205 Fix - Profile picture remove, update and save on the edit profile page (#385)

    * Fix - Profile picture not being removed on edit profile ajax

    * Fix - Profile picture upload on edit profile

    * Fix - Profile picture size issue in edit profile

    * Dev - Conditional logic in profile picture

commit cbe2fde
Author: Dipu chaudhary <34309829+dipuchaudhary@users.noreply.github.com>
Date:   Tue Jan 25 20:13:23 2022 +0545

    UR-192 Fix - File upload data not updated in profile details changed email (#384)

    * Fix - File upload url not updated to admin email while updating profile details

    * Fix - All file updated when multiple file uploaded

commit 50af2c8
Author: Prajjwal Poudel <iamprazol@gmail.com>
Date:   Mon Jan 17 12:59:42 2022 +0545

    Fix - Escaping in checkbox and radion button
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamprazol iamprazol iamprazol approved these changes

@lekhnath005 lekhnath005 lekhnath005 approved these changes

Assignees

@dipuchaudhary dipuchaudhary

Labels
Approved enhancement Merged Tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dipuchaudhary @lekhnath005 @iamprazol