[build] Fix Gradle build on macOS 11.0 Big Sur #2656
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The beta of macOS 11.0 Big Sur comes with AppleClang 12.0, which catches some more warnings with C++ code when building. Because
-Werror
is turned on, this inevitably leads to build failures. There were three main build failures that I've categorized below:wpiutil
-tautological-overlap-compare
opencv
-c11-extensions
Wno-error=c11-extensions
on macOS. I had to add this everywhere that OpenCV headers were included.wpilibOldCommands
-range-loop-analysis
const auto&
withconst auto
:This was the build log after everything was fixed: https://gradle.com/s/hl3d6oryvnzzq