Remove 2022 deprecations except old command-based #4205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starlight220
previously requested changes
May 1, 2022
PeterJohnson
requested changes
May 1, 2022
PeterJohnson
previously approved these changes
May 1, 2022
|
Since the HAL sim changes are likely to break vendor dependencies, I'm going to hold off on merging this. |
|
I'll move the HALSIM removals to a separate PR. Given how hesitant we are to break vendors, this probably wouldn't get merged until beta (September/October). |
PeterJohnson
approved these changes
May 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing old command-based is pending 2022 usage reporting. I also left the Encoder deprecations alone since those don't appear to be intended for removal.