Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[upstream_utils] Fix fmt compilation errors on Windows #5948

Merged
merged 2 commits into from
Nov 21, 2023

Conversation

PeterJohnson
Copy link
Member

@PeterJohnson PeterJohnson commented Nov 21, 2023

Using this-> in decltype doesn't work in the latest MSVC.

@PeterJohnson PeterJohnson requested a review from a team as a code owner November 21, 2023 07:32
@PeterJohnson PeterJohnson merged commit bdc8620 into wpilibsuite:main Nov 21, 2023
26 checks passed
@PeterJohnson PeterJohnson deleted the fmtlib-windows-workaround branch November 21, 2023 16:16
Starlight220 pushed a commit to Starlight220/allwpilib that referenced this pull request Dec 1, 2023
)

Using `this->` in decltype doesn't work in the latest MSVC.
pjreiniger pushed a commit to bzlmodRio/allwpilib that referenced this pull request Dec 4, 2023
)

Using `this->` in decltype doesn't work in the latest MSVC.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant