Use Miklast high resolution field render #6185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good in pathweaver: Field border isn't correct in glass: |
sciencewhiz
force-pushed
the
FixFieldJson2
branch
from
93bc75e
to
7191fff
Compare
This makes it so glass scaling bug doesn't affect field border significantly
|
I cropped the image so that the aspect ratio is 2:1, which virtually matches the aspect ratio of the field, and glass draws the field border correctly.
|
|
That last picture came from an instrumented build of glass, but I think I might have left some functional changes in also. I'll double check with a clean glass build tonight |
|
Looks fine with glass 2024.1.1 also |
|
With #6222 merged it isn't necessary to crop, but I think it's probably better to leave it cropped to waste less space. |
PeterJohnson
approved these changes
Jan 14, 2024
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Image from https://www.chiefdelphi.com/t/2024-crescendo-top-down-field-renders/447764