Use 64 bit timestamp in DMA #6278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeterJohnson
approved these changes
Jan 21, 2024
frc971-automation
pushed a commit
to frc971/971-Robot-Code
that referenced
this pull request
Jan 21, 2024
An update in NI-Libraries made the timestamp out of DMA to be 64 bits, this issue was reported here: wpilibsuite/allwpilib#6276, and a fix was made on the wpilib side here: wpilibsuite/allwpilib#6278, Which we copied the fix over from. Signed-off-by: Maxwell Henderson <mxwhenderson@gmail.com> Change-Id: I0900c9a975549ac3e8872427dfd0cc8151dff188
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6276
Timestamps in DMA are now 64 bits. This means the buffer being read was 1 too small to hold all the data, which caused the DMA buffer to get out of sync with the actual data.
Fix the bug, and also put in a print if this state is ever detected again to report to wpilib. This should never happen if our code is correct.