Update field size defaults in Field2D.cpp #6298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like the field length is longer in 2024. Used the onshape model to measure the size. This was the only place in the codebase I could find the 15.9 number
|
FWIW - it's been off for a little bit - |
|
This only affects when it's used without a field image, right? Which should be much less common with #6225 |
|
Yes, the discovery of this was in Glass and SimGUI without a field background image. At least in 2024.1.1, this is the default for users. |
|
The default changed to the 2024 field in 2024.2.1. |
PeterJohnson
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like the field length is longer in 2024. Used the onshape model to measure the size. This was the only place in the codebase I could find the 15.9 number