Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[🛠️] Change Command Scheduler to fix iterator invalidation bugs and get rid of "hacks" in C++ and Java #6593

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

[🛠️] Change Command Scheduler to fix iterator invalidation bugs and get rid of "hacks" in C++ and Java #6593

wants to merge 18 commits into from
+213 −87

Commits on Oct 10, 2024

  1. fix scheduledCommands.erase() being called in the same sets iterator

    @kytpbs
    kytpbs committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    184566c View commit details
    Browse the repository at this point in the history

  2. added comment explaning why we defer from java 

    this is also to retrigger workflows
    @kytpbs
    kytpbs committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    9c94322 View commit details
    Browse the repository at this point in the history

  3. Formatting fixes

    @github-actions @kytpbs
    github-actions[bot] authored and kytpbs committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    cd753b1 View commit details
    Browse the repository at this point in the history

  4. use small Vector instead 

    size is set to 10, as I don't think any normal team is going to end 20 commands at the same time...
    @kytpbs
    kytpbs committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    23547a2 View commit details
    Browse the repository at this point in the history

  5. create a new SmallSet instead 

    this is similar to the way robot.py has done it, and because we are only copying a pointer array, it shouldn't have a big impact on performance.
    @kytpbs
    kytpbs committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    ec62f62 View commit details
    Browse the repository at this point in the history

  6. create a copy of the m_scheduledCommands 

    this is made to be consistent with C++ due to it not having iterator.Remove() or similar
    @kytpbs
    kytpbs committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    dd60ba0 View commit details
    Browse the repository at this point in the history

  7. remove concurrent avoiding modification member variables (C++)

    @kytpbs
    kytpbs committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    35786d8 View commit details
    Browse the repository at this point in the history

  8. remove concurrent avoiding modification member variables (Java)

    @kytpbs
    kytpbs committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    a905f7b View commit details
    Browse the repository at this point in the history

  9. Formatting fixes

    @github-actions @kytpbs
    github-actions[bot] authored and kytpbs committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    ede024e View commit details
    Browse the repository at this point in the history

  10. remove iterator as we don't need it 

    Co-authored-by: Joseph Eng <91924258+KangarooKoala@users.noreply.github.com>
    @kytpbs @KangarooKoala
    kytpbs and KangarooKoala committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    a7702d0 View commit details
    Browse the repository at this point in the history

  11. Formatting fixes

    @github-actions @kytpbs
    github-actions[bot] authored and kytpbs committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    2f5c5c4 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2024

  1. add a test to cancel the next command from the first 

    Co-authored-by: Joseph Eng <91924258+KangarooKoala@users.noreply.github.com>
    @kytpbs @KangarooKoala
    kytpbs and KangarooKoala committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    7149e43 View commit details
    Browse the repository at this point in the history

  2. add better error messages to C++ tests

    @kytpbs
    kytpbs committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    7c7ca2e View commit details
    Browse the repository at this point in the history

  3. Optimize copying m_scheduledCommands

    @kytpbs
    kytpbs committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    9154940 View commit details
    Browse the repository at this point in the history

  4. add a test checking if command is scheduled on end() call

    @kytpbs
    kytpbs committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    35b02b9 View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2024

  1. Add test for scheduling a command within a command

    @kytpbs
    kytpbs committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    0f5c8e6 View commit details
    Browse the repository at this point in the history

  2. Refactor tests according to reviews 

    Co-Authored-By: Joseph Eng <91924258+KangarooKoala@users.noreply.github.com>
    @kytpbs @KangarooKoala
    kytpbs and KangarooKoala committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    93ad7b8 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2024

  1. move some tests to schedulingRecursionTest & improve comments

    @kytpbs
    kytpbs committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    ada142a View commit details
    Browse the repository at this point in the history