[wpilib] Deprecate MotorController #6648
Open
+15
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spacey-sooty
approved these changes
May 23, 2024
Starlight220
requested changes
May 24, 2024
calcmogul
force-pushed
the
wpilib-deprecate-motor-controller
branch
from
4d16fc7
to
230beb1
Compare
The drive classes no longer need this interface, and it rigidly couples us to motor controller vendors who only update and do a major release of their vendordep once per year. We were originally going to do this in wpilibsuite#6053, but we wanted to gather feedback on the alternate approach during a season first (as far as I know, we received none).
calcmogul
force-pushed
the
wpilib-deprecate-motor-controller
branch
from
230beb1
to
0060841
Compare
Starlight220
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The drive classes no longer need this interface, and it rigidly couples us to motor controller vendors who only update and do a major release of their vendordep once per year.
We were originally going to do this in #6053, but we wanted to gather feedback on the alternate approach during a season first (as far as I know, we received none).