Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wpilibj, wpilibc] Fix LED patterns not offsetting reads #6948

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[wpilibj, wpilibc] Fix LED patterns not offsetting reads #6948

wants to merge 1 commit into from
+249 −4

Conversation

SamCarlberg
Copy link
Member

@SamCarlberg SamCarlberg commented Aug 11, 2024 •
edited
Loading

Was causing bugs when combined with patterns that need to read back from the buffer (eg masks and overlays)

Todo:

  • Java implementation
  • C++ implementation (needs a custom span type for reading with a modulo offset)

Fixes #6824

@SamCarlberg
Fix Java LED patterns not offsetting reads
101fa9f 
Was causing bugs when combined with patterns that need to read back from the buffer (eg masks and overlays)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
component: wpilibc WPILib C++ component: wpilibj WPILib Java
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Offset LED patterns only offset writes, not reads
1 participant
@SamCarlberg