Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Array widgets #812
base: main
Are you sure you want to change the base?
Array widgets #812
Changes from all commits
62c75d5
4fcb776
7393aee
7cee6fa
ca63c58
1041fe7
6599d32
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
newBooleans.clone()
would do this betterThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
float[]
andlong[]
will need to be supported, tooThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I try to change the type from
double[]
toNumber[]
,I get a strange exception:
Shuffleboard seems to think that
NumberArrayWidget
now accepts aSubsystemType
, but I never specified that type anywhere.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Depending on what commit your bench is based on, this may be a different bug that's fixed in #815, where data types aren't correctly loaded. LW Subsystem is interesting though, what does your robot code Shuffleboard setup look like?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have the following in
robotInit
:My branch (
Martysh12/shuffleboard:array-widgets
) is based onwpilibsuite/shuffleboard:main
(commit cdd5e7a, specifically).I actually did try merging
SamCarlberg/shuffleboard:nt-fixes
into my branch and seeing if doing so fixes anything; it looks like it didn't:All entries in my robot-created
Test
tab can only display as a Network Table Tree (when I right click on them), and only the primitives types are auto-populated.Entries under
FMSInfo
seem to display fine, however, and all widgets are available for them:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use
newDoubles.clone()
instead