Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude raw nodes from description #23

Merged
merged 1 commit into from
Oct 1, 2020
Merged

Conversation

TheTripleV
Copy link
Member

closes #22

@Daltz333 Daltz333 merged commit 285768e into wpilibsuite:master Oct 1, 2020
@cranmer
Copy link

cranmer commented Oct 1, 2020

Thanks!

Will this be released on pip?

@TheTripleV
Copy link
Member Author

Yes, it has been released.

@cranmer
Copy link

cranmer commented Oct 1, 2020

Sweet. And will this normally skip text in

and

that would normally be displayed? or will it only skip things like <script> etc. that wouldn't normally be displayed?

@TheTripleV
Copy link
Member Author

This change skips all raw nodes. So for your repo, this should skip the script tags and <br /> that appeared in the description.

In general, invisible nodes, admonitions, raw nodes, and the first header of the page (if it is equivalent to the title metadata) are skipped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

og:description picks up <script... if text is short
3 participants