Use Sphinx Builder method to get page url #89
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR is to generate
og:url
correctly for other dirhtml-based builders.Details
I develop sphinx-revealjs (Sphinx extension to generate presentation) that have
dirrevealjs
builder extendeddirhtml
.I am adding opengraph metatags for
dirrevealjs
outputs usingsphinxext-opengraph
, but it does not work for expected.This has generated
/index.html
forog:url
when usedirrevealjs
builder.But, this should generate
/
ended.(For reproduction, please see my reproduction demo.)
For fix(about diff)
Currently,
get_tags
build page_url manually fordirhtml
.Sphinx builder class has
get_target_uri
for generate document url from pagename to ref page.I hope to use this to build
og:url
.