fix(tabs): Overflow flushed tabs menu doesn't have enough space to place navigation buttons. #441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamleigh
changed the title
iamleigh
reviewed
Mar 4, 2022
There was a problem hiding this comment.
@creador-dev there's a bug. Try adding tabs with long names and notice right arrow to start navigating doesn't appear. To show it up, you need to scroll to right first.
iamleigh
suggested changes
Mar 4, 2022
There was a problem hiding this comment.
@creador-dev there's a bug. As shown in the screenshot below, try adding tabs with long names and notice right arrow to start navigating doesn't appear. To show it up, you need to scroll to right first.
creador-dev
changed the title
iamleigh
changed the title
iamleigh
suggested changes
Mar 9, 2022
There was a problem hiding this comment.
@creador-dev review again your changes. There is something that's causing an alignment issue in the tab buttons label. Also, they're not overflowing correctly.
…into fix/SUI-282
creador-dev
changed the title
iamleigh
changed the title
iamleigh
approved these changes
Mar 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.