fix(insert-variables): Dropdown shouldn't store the option selected. #468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
creador-dev
changed the title
iamleigh
suggested changes
Feb 28, 2022
iamleigh
changed the title
iamleigh
changed the title
iamleigh
suggested changes
Mar 4, 2022
There was a problem hiding this comment.
@creador-dev review again your changes, please. Remember, if developers use the SUI.select.initVars function they need to get everything from it. There's no need to re-add the clear function again because if it doesn't work right now on the showcase it won't for sure on the plugins. Dig a bit more and try a better solution.
creador-dev
changed the title
creador-dev
changed the title
iamleigh
suggested changes
Mar 9, 2022
iamleigh
changed the title
iamleigh
suggested changes
Mar 13, 2022
|
|
||
| let select = $( this ); | ||
|
|
||
| select.val( null ).trigger( 'change' ); |
There was a problem hiding this comment.
@creador-dev why not try clearing the selected value when the dropdown closes? You will simplify the code, and also we make sure to have the best experience for screen reader users.
iamleigh
approved these changes
Mar 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.