Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing dependencies to some packages #304

Merged
merged 7 commits into from
Jul 9, 2024

Conversation

abder
Copy link
Collaborator

@abder abder commented Jul 3, 2024

@emgk

  • Added @wpmudev/sui-css, @wpmudev/sui-icons, @wpmudev/sui-hooks, and @wpmudev/sui-utils to the deps list of @wpmudev/sui-react so all necassary packes will be available with the install of @wpmudev/sui-react

  • Added @wpmudev/sui-react package installation instructions to the Overview page

Copy link

changeset-bot bot commented Jul 3, 2024

⚠️ No Changeset found

Latest commit: 12e23b4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@abder abder marked this pull request as ready for review July 4, 2024 11:11
@abder abder requested a review from emgk July 4, 2024 11:11
@emgk
Copy link
Collaborator

emgk commented Jul 9, 2024

As discussed, we will keep CSS and icon packages separate from the @wpmudev/sui-react package for now.

Although including them in @wpmudev/sui-react package wouldn't affect final size due to tree-shaking, it could:

  • Increase the size of the node_modules folder.
  • Cause dependency conflicts if dev want to use different versions of icons or CSS than what's included in @wpmudev/sui-react

@wpmudev/sui-react should only contain components, hooks, and utils. since CSS and icons aren't strictly dependent on React, it's better to keep them separate.

@emgk emgk merged commit a9c5853 into development Jul 9, 2024
1 check passed
@emgk emgk deleted the fix-missing-dependencies branch July 9, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants