Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: translated example code #2226

Merged
merged 9 commits into from
Jul 18, 2024
Merged

Conversation

gekkedev
Copy link
Contributor

@gekkedev gekkedev commented Jun 18, 2024

  • not sure if I translated Jen correctly as "jeans"
  • Yarn installation example added since it is a fairly common package manager

@gekkedev gekkedev marked this pull request as ready for review June 19, 2024 10:56
@gekkedev
Copy link
Contributor Author

@icleitoncosta could you check? It's just some translations

Copy link
Contributor

@icleitoncosta icleitoncosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good, in the next commits, please send commit name with "docs: text......" for docs ou "fix: text..." for texts, for not have error of lint

Copy link

@icleitoncosta, ⭐3 XP earned, 🏆First Code Review Done completed, 💪Level 10 achieved! [Details]

icon

@icleitoncosta icleitoncosta merged commit 91b2c40 into wppconnect-team:master Jul 18, 2024
4 of 5 checks passed
Copy link

Pull Request Summary by devActivity

Metrics

Cycle Time: 30d 7h 48m Coding Time: < 1 min Pickup Time: 30d 7h 47m Review Time: < 1 min Comments: 2

Achievements

@gekkedev gekkedev deleted the patch-3 branch July 19, 2024 08:16
@gekkedev
Copy link
Contributor Author

Thanks for the hint, so even if we squash-merge (hopefully^^) there will be conventional commit checks? I'll keep that in mind for future commits.

gekkedev added a commit to gekkedev/wppconnect that referenced this pull request Jul 23, 2024
gekkedev added a commit to gekkedev/wppconnect that referenced this pull request Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants