Skip to content

Commit

Permalink
Fixed small indexing error of rhoair in ISHMAEL MP scheme (#1802)
Browse files Browse the repository at this point in the history
Small indexing error of rhoair, old indexing used cc, everywhere else in code k is used.

TYPE: bug fix

KEYWORDS: Microphysics, ISHMAEL, indexing, minor

SOURCE: Dylan Reynolds (SLF)

DESCRIPTION OF CHANGES:
Problem:
indexing error

Solution:
changed index

TESTS CONDUCTED:
None using WRF -- ISHMAEL is being tested in the HICAR model where this bug was found.
The Jenkins tests have passed.

RELEASE NOTE: Fixed an indexing error in ISHMAEL MP. Minor improvement.
  • Loading branch information
d-reynolds authored Jan 19, 2023
1 parent c763949 commit 130e42c
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions phys/module_mp_jensen_ishmael.F
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ module module_mp_jensen_ishmael
!------------------------------------------------------------------------------------------------------!

use module_wrf_error

implicit none !.. You are welcome

!.. Constants
Expand Down Expand Up @@ -1381,7 +1381,7 @@ subroutine me_ishmael(it, kts, kte, i, j, dt, pres_e, dzmic, &
if(temp.gt.T0) then
!.. Melting: ice shapes become more spherical
qmlt(cc)=2.*PI*(kt*fh(cc)*(T0-temp)+rhoair(cc)*xxlv*dv*fv(cc)*(qs0-qv(k)))/ &
qmlt(cc)=2.*PI*(kt*fh(cc)*(T0-temp)+rhoair(k)*xxlv*dv*fv(cc)*(qs0-qv(k)))/ &
xxlf*(ni(cc,k)*NU*max(ani(cc),cni(cc))) - &
(CPW/xxlf*(temp-T0)*(rimetotal(cc)/rhoair(k) + dQImltri(cc)))
Expand Down Expand Up @@ -4709,4 +4709,3 @@ SUBROUTINE AVINT(X,Y,N,XLO,XUP,ANS)
end module module_mp_jensen_ishmael

!.. Full stop

0 comments on commit 130e42c

Please sign in to comment.