Skip to content

Commit

Permalink
Make script more portable by changing == to = (#1871)
Browse files Browse the repository at this point in the history
TYPE: bug fix

KEYWORDS: configure script, use '=' vs '=='

SOURCE: Chris Bridgham

DESCRIPTION OF CHANGES:
Problem:
The newly added test in v4.5 in configure script could fail due to less portable use '==' as in 
```
if [ $rpc_type == "rpc" ]; then
```

Solution:
Change the above to
```
if [ $rpc_type = "rpc" ]; then
```

ISSUE: For use when this PR closes an issue.
Fixes #1869

LIST OF MODIFIED FILES: 
M     configure

TESTS CONDUCTED: 
1. Yes.
2. The Jenkins tests are all passing.
  • Loading branch information
weiwangncar authored Jun 29, 2023
1 parent c10e788 commit 1bab38b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion configure
Original file line number Diff line number Diff line change
Expand Up @@ -1043,7 +1043,7 @@ rm -f tools/rpc_test.log

if [ -f tools/rpc_test.exe ] ; then
rpc_type=`tools/rpc_test.exe`
if [ $rpc_type == "rpc" ]; then
if [ $rpc_type = "rpc" ]; then
sed -e '/^CFLAGS_LOCAL/s/#/-DRPC_TYPES=1 &/' configure.wrf > configure.wrf.edit
else
sed -e '/^CFLAGS_LOCAL/s/#/-DRPC_TYPES=2 &/' configure.wrf > configure.wrf.edit
Expand Down

0 comments on commit 1bab38b

Please sign in to comment.