Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

radar_rhv_opt==2 array allocation error #2077

Closed
apsims2001 opened this issue Jul 9, 2024 · 2 comments
Closed

radar_rhv_opt==2 array allocation error #2077

apsims2001 opened this issue Jul 9, 2024 · 2 comments
Assignees

Comments

@apsims2001
Copy link

In the file:
WRF/var/da/da_radar/da_get_innov_vector_radar.inc

line 277 & line 278 are the same (duplicate allocation)
allocate (avg_qws(tot_h_index,tot_z_index))
allocate (avg_qws(tot_h_index,tot_z_index))

When using radar_rhv_opt == 2 this is causes a runtime crash

Steps to reproduce the behavior:
USE_RADAR_RHV = T,
RADAR_RHV_OPT = 2,
Tested with intel classic compiler [ifort (IFORT) 2021.10.0 20230609]

  1. Output is '....'
forrtl: severe (151): allocatable array is already allocated
Image              PC                Routine            Line        Source
da_wrfvar.exe      0000000000F7A164  Unknown               Unknown  Unknown
da_wrfvar.exe      0000000000B59CA2  Unknown               Unknown  Unknown
da_wrfvar.exe      0000000000429C4C  Unknown               Unknown  Unknown
da_wrfvar.exe      0000000000421532  Unknown               Unknown  Unknown
da_wrfvar.exe      0000000000418877  Unknown               Unknown  Unknown
da_wrfvar.exe      000000000040C72D  Unknown               Unknown  Unknown
libc.so.6          00000F195B629D90  Unknown               Unknown  Unknown
libc.so.6          00000F195B629E40  __libc_start_main     Unknown  Unknown
da_wrfvar.exe      000000000040C645  Unknown               Unknown  Unknown

Commenting out the duplicate line and recompiling fixes the problem for me

@weiwangncar
Copy link
Collaborator

@mos3r3n I wonder if you have an interest to take a look?

@weiwangncar
Copy link
Collaborator

@apsims2001 The problem like this should be posted to the Support Forum: https://forum.mmm.ucar.edu/. Thanks.

liujake pushed a commit that referenced this issue Aug 1, 2024
… 2 (#2078)

TYPE: bug fix

KEYWORDS: radar DA

DESCRIPTION OF CHANGES:
Problem:
Duplicated allocation of avg_qws when choosing radar_rhv_opt = 2.
da_free_unit instead of da_get_unit for closing a file when radar_rhv_opt is equal to 2.

ISSUE: #2077 

LIST OF MODIFIED FILES:
var/da/da_radar/da_get_innov_vector_radar.inc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants