Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add superobbing for AHI #1173

Merged
merged 2 commits into from
May 27, 2020
Merged

Add superobbing for AHI #1173

merged 2 commits into from
May 27, 2020

Conversation

YaliWu0219
Copy link
Contributor

@YaliWu0219 YaliWu0219 commented Apr 17, 2020

TYPE: new feature

KEYWORDS: superobbing, cloud detection, cloud fraction, AHI

SOURCE: Yali Wu (NCAR/MMM), Jonathan Guerrette (NCAR/MMM).

DESCRIPTION OF CHANGES: This PR adds a new function of superobbing AHI radiances and retrieving cloud fraction based on AHI cloud detection results. The default namelist parameter ahi_superob_halfwidth is set to zero, which means no superobbing will be applied.

ISSUE: no issue

LIST OF MODIFIED FILES:
M Registry/registry.var
M var/da/da_define_structures/da_define_structures.f90
M var/da/da_monitor/da_rad_diags.f90
M var/da/da_radiance/da_allocate_rad_iv.inc
M var/da/da_radiance/da_deallocate_radiance.inc
M var/da/da_radiance/da_initialize_rad_iv.inc
M var/da/da_radiance/da_qc_ahi.inc
M var/da/da_radiance/da_radiance.f90
M var/da/da_radiance/da_radiance1.f90
M var/da/da_radiance/da_read_obs_netcdf4ahi_jaxa.inc
M var/da/da_radiance/da_write_iv_rad_ascii.inc
M var/da/da_radiance/da_write_oa_rad_ascii.inc

TESTS CONDUCTED:
This capability has been tested in generating one-month AHI obs files for MPAS-JEDI DA purpose. WRFDA regression tests passed.

A simple comparison between using thinning and superobbing:
image
And a figure of cloud fraction product from a typhoon event:
image

@davegill
Copy link
Contributor

@YaliWu0219
I am seeing a failure for one of the tests.

It is possible that we fixed this problem in release-v4.2, since I do not see this problem with the release-v4.2 tests that have been conducted for the last few weeks.

In a separate (throw away) branch, merge your mods into release-v4.2, and then submit that test branch as a PR. If all of the regression tests PASS in that test PR, post that information in this PR commit message.

@davegill
Copy link
Contributor

@YaliWu0219
Here are the jenkins test results:

Please find result of the WRF regression test cases in the attachment. This build is for Commit ID: 6735270dd3af552d8e2bb067466dc82f3f2ee701, requested by: YaliWu0219 for PR: https://github.com/wrf-model/WRF/pull/1173. For any query please send e-mail to David Gill.

    Test Type              | Expected  | Received |  Failed
    = = = = = = = = = = = = = = = = = = = = = = = =  = = = =
    Number of Tests        : 18           18
    Number of Builds       : 46           46
    Number of Simulations  : 164           164         3
    Number of Comparisons  : 104           102         0

    Failed Simulations are: 
    output_1:9 = STATUS test_001s em em_real 32 rap
output_1:9 = STATUS test_001o em em_real 33 rap
output_1:9 = STATUS test_001m em em_real 34 rap
    Which comparisons are not bit-for-bit: 
    None

When I look at the output for the "rap" namelist:

Backtrace for this error:
#0  0x14cb27463dfd in ???
#1  0x14cb27463013 in ???
#2  0x14cb2695b3af in ???
#3  0x2ada3d8 in __module_sf_mynn_MOD_psim_stable
        at /wrf/WRF/phys/module_sf_mynn.f90:2050
#4  0x2adab5c in __module_sf_mynn_MOD_zolri2
        at /wrf/WRF/phys/module_sf_mynn.f90:1965
#5  0x2adae16 in __module_sf_mynn_MOD_zolri
        at /wrf/WRF/phys/module_sf_mynn.f90:1912

@YaliWu0219
Copy link
Contributor Author

@davegill Thank you for showing me this information. It seems that there's no response when I click Details. I will try that on release-v4.2.

@davegill
Copy link
Contributor

@YaliWu0219
Yes, that "click details" button does not work. We are not sure how to get rid of it!

If you have questions on how to set up the temporary test branch, please send email to gill@ucar.edu

@weiwangncar
Copy link
Collaborator

@YaliWu0219 At the moment, the WRF model only computes cloud fraction as a diagnostics for radiation. Do you expect more from the model?

@liujake
Copy link
Contributor

liujake commented Apr 17, 2020

@weiwangncar This is nothing to do with model cloud fraction.

@YaliWu0219 YaliWu0219 mentioned this pull request Apr 17, 2020
@liujake
Copy link
Contributor

liujake commented May 25, 2020

@YaliWu0219
Here are the jenkins test results:

Please find result of the WRF regression test cases in the attachment. This build is for Commit ID: 6735270dd3af552d8e2bb067466dc82f3f2ee701, requested by: YaliWu0219 for PR: https://github.com/wrf-model/WRF/pull/1173. For any query please send e-mail to David Gill.

    Test Type              | Expected  | Received |  Failed
    = = = = = = = = = = = = = = = = = = = = = = = =  = = = =
    Number of Tests        : 18           18
    Number of Builds       : 46           46
    Number of Simulations  : 164           164         3
    Number of Comparisons  : 104           102         0

    Failed Simulations are: 
    output_1:9 = STATUS test_001s em em_real 32 rap
output_1:9 = STATUS test_001o em em_real 33 rap
output_1:9 = STATUS test_001m em em_real 34 rap
    Which comparisons are not bit-for-bit: 
    None

When I look at the output for the "rap" namelist:

Backtrace for this error:
#0  0x14cb27463dfd in ???
#1  0x14cb27463013 in ???
#2  0x14cb2695b3af in ???
#3  0x2ada3d8 in __module_sf_mynn_MOD_psim_stable
        at /wrf/WRF/phys/module_sf_mynn.f90:2050
#4  0x2adab5c in __module_sf_mynn_MOD_zolri2
        at /wrf/WRF/phys/module_sf_mynn.f90:1965
#5  0x2adae16 in __module_sf_mynn_MOD_zolri
        at /wrf/WRF/phys/module_sf_mynn.f90:1912

@davegill Is this issue in the 'develop' branch (not in v4.2 branch) already fixed?

@davegill
Copy link
Contributor

@liujake

Is this issue in the 'develop' branch (not in v4.2 branch) already fixed?

Jake,
Yes.

@YaliWu0219 YaliWu0219 requested review from a team as code owners May 26, 2020 16:40
@liujake liujake merged commit ace4756 into wrf-model:develop May 27, 2020
liujake added a commit that referenced this pull request Jan 17, 2024
TYPE: new feature

KEYWORDS: ABI, cloud detection, all-sky obs error model

SOURCE: JJ Guerrette (NCAR/MMM, now at tomorrow.io), Deqin Li (Liaoning Meteorological Bureau of CMA), Jake Liu (NCAR/MMM)

DESCRIPTION OF CHANGES:
This PR addes the assimilation of GOES-16/17 ABI's 3 water vapor channels' radiance data. This includes reading of ABI's full-disk, CONUS, and meso1&2 data files, superobbing and thinning of ABI data, IR-based cloud detection scheme as part of quality control, and all-sky obs error model. Cloud detection scheme should be the same as for AHI in principle, but the actual code implementation is not the same. No attempt made to make ABI's cloud detection code consistent with AHI's when bringing the code originally developed back in 2019-2020 into the latest develop branch. Some technical information is provided below for the use of this new capability.

1. Read ABI files:
Raw netcdf ABI data files (one file for one channel) need to be listed in 4 list files:
'file_list_GOES-16-ABI_C' for CONUS scan files
'file_list_GOES-16-ABI_F'  for full-disk scan files (e.g., OR_ABI-L1b-RadF-M6C08_G16_s20191211200263_e20191211209571_c20191211210021.nc)
'file_list_GOES-16-ABI_M1' for meso1 scan files
'file_list_GOES-16-ABI_M2' for meso2 scan files

ABI data reading code will automatically determine which file(s) to read in matching ABI file's time and analysis time.

2. Cloud detection scheme needs to read in a terrain file OR_ABI-TERR_G16.nc or OR_ABI-TERR_G17.nc for GOES-16 ABI or GOES-17 ABI.

3. Related namelist settings:
```
&wrfvar4
 use_goesabiobs  = true, ! read goes-16 and goes-17 ABI data
/
```
```
&wrfvar14
 rtminit_nsensor= 1,
 rtminit_platform=  4, ! goes
 rtminit_satid=  16,      ! goes-16
 rtminit_sensor=  44,  ! abi
 thinning= true,
 thinning_mesh= 30.0,
 qc_rad=true,
 write_iv_rad_ascii=true,
 write_oa_rad_ascii=true,
 rtm_option= 2,
 crtm_cloud= false,
 only_sea_rad=false,
 use_varbc=true,
 varbc_nobsmin=500,
 crtm_irland_coef= "IGBP.IRland.EmisCoeff.bin",
 use_clddet_zz=true, ! IR-based cloud detection
 abi_superob_halfwidth=3, ! this will do supperobbing with 7x7 pixels
 /
```

See also AHI DA related PRs:
#1139
#1173
#1774

LIST OF MODIFIED FILES: 41
M       Registry/registry.var
M       var/build/depend.txt
M       var/da/da_define_structures/da_define_structures.f90
M       var/da/da_monitor/da_rad_diags.f90
M       var/da/da_radiance/da_allocate_rad_iv.inc
M       var/da/da_radiance/da_deallocate_radiance.inc
M       var/da/da_radiance/da_get_innov_vector_crtm.inc
M       var/da/da_radiance/da_get_innov_vector_rttov.inc
A       var/da/da_radiance/da_get_sat_angles.inc
A       var/da/da_radiance/da_get_sat_angles_1d.inc
A       var/da/da_radiance/da_get_solar_angles.inc
A       var/da/da_radiance/da_get_solar_angles_1d.inc
M       var/da/da_radiance/da_initialize_rad_iv.inc
A       var/da/da_radiance/da_qc_goesabi.inc
M       var/da/da_radiance/da_qc_rad.inc
M       var/da/da_radiance/da_radiance.f90
M       var/da/da_radiance/da_radiance1.f90
M       var/da/da_radiance/da_radiance_init.inc
A       var/da/da_radiance/da_read_obs_ncgoesabi.inc
M       var/da/da_radiance/da_rttov.f90
M       var/da/da_radiance/da_setup_radiance_structures.inc
M       var/da/da_radiance/da_write_iv_rad_ascii.inc
M       var/da/da_radiance/da_write_oa_rad_ascii.inc
M       var/da/da_radiance/module_radiance.f90
M       var/da/da_setup_structures/da_setup_obs_structures.inc
M       var/da/da_setup_structures/da_setup_structures.f90
A       var/da/da_tools/da_llxy_1d.inc
A       var/da/da_tools/da_llxy_default_1d.inc
A       var/da/da_tools/da_llxy_global_1d.inc
A       var/da/da_tools/da_llxy_kma_global_1d.inc
A       var/da/da_tools/da_llxy_latlon_1d.inc
A       var/da/da_tools/da_llxy_lc_1d.inc
A       var/da/da_tools/da_llxy_merc_1d.inc
A       var/da/da_tools/da_llxy_ps_1d.inc
A       var/da/da_tools/da_llxy_rotated_latlon_1d.inc
A       var/da/da_tools/da_llxy_wrf_1d.inc
A       var/da/da_tools/da_togrid_1d.inc
M       var/da/da_tools/da_tools.f90
M       var/run/VARBC.in
A       var/run/radiance_info/goes-16-abi.info
A       var/run/radiance_info/goes-17-abi.info

TESTS CONDUCTED: 
1. WRFDA regression test passed on Derecho.
2. Clear-sky ABI DA is tested with a full-disk data file. 
3. the Jenkins tests all passing.

RELEASE NOTE: Add the capability for assimilating GOES-ABI radiance data
vlakshmanan-scala pushed a commit to scala-computing/WRF that referenced this pull request Apr 4, 2024
TYPE: new feature

KEYWORDS: superobbing, cloud detection, cloud fraction, AHI 

SOURCE: Yali Wu (NCAR/MMM), Jonathan Guerrette (NCAR/MMM).

DESCRIPTION OF CHANGES: This PR adds a new function of superobbing AHI radiances and retrieving cloud fraction based on AHI cloud detection results. The default namelist parameter `ahi_superob_halfwidth` is set to zero, which means no superobbing will be applied.  

ISSUE: no issue

LIST OF MODIFIED FILES: 
M       Registry/registry.var
M       var/da/da_define_structures/da_define_structures.f90
M       var/da/da_monitor/da_rad_diags.f90
M       var/da/da_radiance/da_allocate_rad_iv.inc
M       var/da/da_radiance/da_deallocate_radiance.inc
M       var/da/da_radiance/da_initialize_rad_iv.inc
M       var/da/da_radiance/da_qc_ahi.inc
M       var/da/da_radiance/da_radiance.f90
M       var/da/da_radiance/da_radiance1.f90
M       var/da/da_radiance/da_read_obs_netcdf4ahi_jaxa.inc
M       var/da/da_radiance/da_write_iv_rad_ascii.inc
M       var/da/da_radiance/da_write_oa_rad_ascii.inc

TESTS CONDUCTED:
This capability has been tested in generating one-month AHI obs files for MPAS-JEDI DA purpose. WRFDA regression tests passed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants