Fixes occasional instabilities in the surface layer option 1 #1286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pedro-jm Does this mean the model will never hit nzol+1 = 1000? |
|
It hits it but uses the full function instead of the table when
it is outside the table range.
…On Mon, Sep 14, 2020 at 4:04 PM weiwangncar ***@***.***> wrote:
@pedro-jm <https://github.com/pedro-jm> Does this mean the model will
never hit nzol+1 = 1000?
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#1286 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEIZ77GN5KHDB7VYWTUUFGDSF2HPXANCNFSM4RL2EMLA>
.
|
davegill
changed the title
|
@pedro-jm |
|
@davegill |
Jimy, |
|
I only know it is related to the boundary of the look-up table
but I don't know why at this time.
…On Fri, Sep 18, 2020 at 8:42 AM Dave Gill ***@***.***> wrote:
@dudhia <https://github.com/dudhia>
Would you explicitly state why the ".lt. 1000" was a problem and the ".le.
1000" was the answer. Just a sentence. Is this some boundary of a look-up
table?
Jimy,
Any idea why this PR fixes a problem?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1286 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEIZ77COG5EMYBVEYHPGHLTSGNWU7ANCNFSM4RL2EMLA>
.
|
|
reopening for testing |
|
reopen for testing |
|
reopen for testing |
|
reopen |
|
I'm ok with this PR. |
|
@weiwangncar @dudhia |
weiwangncar
approved these changes
Oct 23, 2020
vlakshmanan-scala
pushed a commit
to scala-computing/WRF
that referenced
this pull request
Apr 4, 2024
…1286) TYPE: bug fix KEYWORDS: occasional instabilities, sfclayrev, look up tables SOURCE: Pedro A. Jimenez (NCAR/RAL) DESCRIPTION OF CHANGES: Problem: For some occasions the model turns unstable, and this was found to be originating due to the surface layer option 1, with the upper boundary values of the look up tables. Solution: Avoiding using the look up tables of the integrated similarity functions for the last tabulated value. LIST OF MODIFIED FILES: M phys/module_sf_sfclayrev.F TESTS CONDUCTED: After introducing the fix the model no longer turns unstable in the specific instances noted. The jenkins tests are all PASS. RELEASE NOTE: A minor fix (excluding use of the upper bounding value of the look-up table) was introduced to avoid occasional instabilities in the surface layer option 1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TYPE: bug fix
KEYWORDS: occasional instabilities, sfclayrev, look up tables
SOURCE: Pedro A. Jimenez (NCAR/RAL)
DESCRIPTION OF CHANGES:
Problem:
For some occasions the model turns unstable, and this was found to be originating due to the surface layer option 1, with
the upper boundary values of the look up tables.
Solution:
Avoiding using the look up tables of the integrated similarity functions for the last tabulated value.
LIST OF MODIFIED FILES:
M phys/module_sf_sfclayrev.F
TESTS CONDUCTED:
RELEASE NOTE: A minor fix (excluding use of the upper bounding value of the look-up table) was introduced to avoid occasional instabilities in the surface layer option 1.