Fix examples.namelist namelist record name: domains #1340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TYPE: text only KEYWORDS: namelist, readme SOURCE: internal DESCRIPTION OF CHANGES: In a readme file, one of the helpful suggestions had a misspelled namelist record. It should be `domains`, and it was referred to as `domain`. LIST OF MODIFIED FILES: M test/em_real/examples.namelist TESTS CONDUCTED: 1. This readme is not part of the build process, or part of compilable code. It will have no impact of results. Users likely also just skip past the incorrect namelist record identifier and grab the intended variable (traj_opt). All in all, pretty small potatoes.
|
@smileMchen |
|
@smileMchen |
|
@davegill |
smileMchen
approved these changes
Jan 7, 2021
vlakshmanan-scala
pushed a commit
to scala-computing/WRF
that referenced
this pull request
Apr 4, 2024
TYPE: text only KEYWORDS: namelist, readme SOURCE: internal DESCRIPTION OF CHANGES: The trajectory examples.namelist was no longer providing sufficient info to run trajectories. 1. One of the helpful suggestions had a misspelled namelist record. It should have been `domains`, but it was referred to as `domain`. 2. There was no info on the additional options required: `dm_has_traj`. 3. There was no mention of the now mandatory additional text file `wrfinput_traj_d01` that has two namelist records. LIST OF MODIFIED FILES: M test/em_real/examples.namelist TESTS CONDUCTED: 1. This readme is not part of the build process, or part of compilable code. It will have no impact of results. Users likely also just skip past the incorrect namelist record identifier and grab the intended variable (num_traj). All in all, pretty small potatoes. 2. The jenksins tests pass, but no surprise - since we did not change anything that is part of the build.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TYPE: text only
KEYWORDS: namelist, readme
SOURCE: internal
DESCRIPTION OF CHANGES:
The trajectory examples.namelist was no longer providing sufficient info to run trajectories.
domains, but it was referredto as
domain.dm_has_traj.wrfinput_traj_d01that has two namelist records.LIST OF MODIFIED FILES:
M test/em_real/examples.namelist
TESTS CONDUCTED:
have no impact of results. Users likely also just skip past the incorrect namelist record
identifier and grab the intended variable (num_traj). All in all, pretty small potatoes.