Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove necessity to run 'run_me_first' scripts for ideal cases #1415

Merged
merged 4 commits into from
Feb 25, 2021

Conversation

davegill
Copy link
Contributor

@davegill davegill commented Feb 25, 2021

TYPE: enhancement

KEYWORDS: ideal, run_me_first.csh, link, Makefile,

SOURCE: Internal

DESCRIPTION OF CHANGES:
Problem:
Several ideal cases (em_b_wave, em_convrad, em_quarter_ss, em_scm_xy, em_seabreeze2d_x, and em_tropical_cyclone)
need additional linked files to run. Previously it was necessary for users to run a script called 'run_me_first.csh' to
link-in the necessary files.

Solution:
Removed all 'run_me_first.csh' scripts from ideal case directories and modified the top-level Makefile so that now the
files are linked during the compile.

LIST OF MODIFIED FILES:
M Makefile
D test/em_b_wave/run_me_first.csh
D test/em_convrad/run_me_first.csh
D test/em_quarter_ss/run_me_first.csh
D test/em_scm_xy/run_me_first.csh
D test/em_seabreeze2d_x/run_me_first.csh
D test/em_tropical_cyclone/run_me_first.csh

TESTS CONDUCTED:

  1. Ensured that code compiles and required files are linked for all modified ideal cases.
  2. Jenkins is all pass.

RELEASE NOTE: It is no longer necessary to execute a 'run_me_first.csh' script for any of the idealized cases. All necessary physics input files and look-up tables are linked to the corresponding directory during the compilation step.

kkeene44 and others added 4 commits February 17, 2021 13:47
KEYWORDS: ideal, run_me_first.csh, link, Makefile

SOURCE: Internal

DESCRIPTION OF CHANGES:
Problem:
Several ideal cases (em_b_wave, em_convrad, em_quarter_ss, em_scm_xy, em_seabreeze2d_x, and em_tropical_cyclone)
need additional linked files to run. Previously it was necessary for users to run a script called 'run_me_first.csh' to
link-in the necessary files.

Solution:
Removed all 'run_me_first.csh' scripts from ideal case directories and modified the top-level Makefile so that now the
files are linked during the compile.

LIST OF MODIFIED FILES:
M       Makefile
D       test/em_b_wave/run_me_first.csh
D       test/em_convrad/run_me_first.csh
D       test/em_quarter_ss/run_me_first.csh
D       test/em_scm_xy/run_me_first.csh
D       test/em_seabreeze2d_x/run_me_first.csh
D       test/em_tropical_cyclone/run_me_first.csh

TESTS CONDUCTED:
1. Ensured that code compiles and required files are linked for all modified ideal cases.
2. Jenkins is all pass.

RELEASE NOTE: It is no longer necessary to execute a 'run_me_first.csh' script for any of the idealized cases. All necessary physics input files and look-up tables are linked to the corresponding directory during the compilation step.
@davegill
Copy link
Contributor Author

replaces PR #1406 "Remove requirement to run 'run_me_first' scripts for ideal cases"

@davegill
Copy link
Contributor Author

@kkeene44
Kelly,
After the p3 PR, you had six conflicts, because Hugh updated all the files and you deleted all of the files. The git source manager was scratching its head. I tried to push the fixes (basically - delete everything) to your branch, but I was not powerful enough.

Anyways, once the jenkins tests pass, I'll send you a note, and then would you please approve this (originally your) PR? When this PR becomes super important, now I'll always be remembered as the author.

@davegill
Copy link
Contributor Author

jenkins:

Please find result of the WRF regression test cases in the attachment. This build is for Commit ID: afeab4ec0e34598091fa93f776a7a7dd0b7782fd, requested by: davegill for PR: https://github.com/wrf-model/WRF/pull/1415. For any query please send e-mail to David Gill.

    Test Type              | Expected  | Received |  Failed
    = = = = = = = = = = = = = = = = = = = = = = = =  = = = =
    Number of Tests        : 19           18
    Number of Builds       : 48           46
    Number of Simulations  : 163           161        0
    Number of Comparisons  : 103           102        0

    Failed Simulations are: 
    None
    Which comparisons are not bit-for-bit: 
    None

@davegill
Copy link
Contributor Author

@kkeene44
Please review YOUR PR, and commit.
Jenkins is OK.
The "run_me's" are gone.

@davegill davegill changed the title Dev+run me first Remove requirement to run 'run_me_first' scripts for ideal cases Feb 25, 2021
@weiwangncar
Copy link
Collaborator

@kkeene44 @davegill Maybe we can change 'Remove requirement... ' to 'Remove necessity... ' in the title of this PR?

@davegill davegill changed the title Remove requirement to run 'run_me_first' scripts for ideal cases Remove necessity to run 'run_me_first' scripts for ideal cases Feb 25, 2021
@davegill davegill merged commit 398dca0 into wrf-model:develop Feb 25, 2021
vlakshmanan-scala pushed a commit to scala-computing/WRF that referenced this pull request Apr 4, 2024
…odel#1415)

TYPE: enhancement

KEYWORDS: ideal, run_me_first.csh, link, Makefile, 

SOURCE: Internal

DESCRIPTION OF CHANGES:
Problem:
Several ideal cases (em_b_wave, em_convrad, em_quarter_ss, em_scm_xy, em_seabreeze2d_x, and em_tropical_cyclone) 
need additional linked files to run. Previously it was necessary for users to run a script called 'run_me_first.csh' to 
link-in the necessary files.  

Solution:
Removed all 'run_me_first.csh' scripts from ideal case directories and modified the top-level Makefile so that now the 
files are linked during the compile.

LIST OF MODIFIED FILES: 
M       Makefile
D       test/em_b_wave/run_me_first.csh
D       test/em_convrad/run_me_first.csh
D       test/em_quarter_ss/run_me_first.csh
D       test/em_scm_xy/run_me_first.csh
D       test/em_seabreeze2d_x/run_me_first.csh
D       test/em_tropical_cyclone/run_me_first.csh

TESTS CONDUCTED: 
1. Ensured that code compiles and required files are linked for all modified ideal cases.
2. Jenkins is all pass.

RELEASE NOTE: It is no longer necessary to execute a 'run_me_first.csh' script for any of the idealized cases. All necessary physics input files and look-up tables are linked to the corresponding directory during the compilation step.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants