-
Notifications
You must be signed in to change notification settings - Fork 700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove necessity to run 'run_me_first' scripts for ideal cases #1415
Conversation
KEYWORDS: ideal, run_me_first.csh, link, Makefile SOURCE: Internal DESCRIPTION OF CHANGES: Problem: Several ideal cases (em_b_wave, em_convrad, em_quarter_ss, em_scm_xy, em_seabreeze2d_x, and em_tropical_cyclone) need additional linked files to run. Previously it was necessary for users to run a script called 'run_me_first.csh' to link-in the necessary files. Solution: Removed all 'run_me_first.csh' scripts from ideal case directories and modified the top-level Makefile so that now the files are linked during the compile. LIST OF MODIFIED FILES: M Makefile D test/em_b_wave/run_me_first.csh D test/em_convrad/run_me_first.csh D test/em_quarter_ss/run_me_first.csh D test/em_scm_xy/run_me_first.csh D test/em_seabreeze2d_x/run_me_first.csh D test/em_tropical_cyclone/run_me_first.csh TESTS CONDUCTED: 1. Ensured that code compiles and required files are linked for all modified ideal cases. 2. Jenkins is all pass. RELEASE NOTE: It is no longer necessary to execute a 'run_me_first.csh' script for any of the idealized cases. All necessary physics input files and look-up tables are linked to the corresponding directory during the compilation step.
replaces PR #1406 "Remove requirement to run 'run_me_first' scripts for ideal cases" |
@kkeene44 Anyways, once the jenkins tests pass, I'll send you a note, and then would you please approve this (originally your) PR? When this PR becomes super important, now I'll always be remembered as the author. |
jenkins:
|
@kkeene44 |
…odel#1415) TYPE: enhancement KEYWORDS: ideal, run_me_first.csh, link, Makefile, SOURCE: Internal DESCRIPTION OF CHANGES: Problem: Several ideal cases (em_b_wave, em_convrad, em_quarter_ss, em_scm_xy, em_seabreeze2d_x, and em_tropical_cyclone) need additional linked files to run. Previously it was necessary for users to run a script called 'run_me_first.csh' to link-in the necessary files. Solution: Removed all 'run_me_first.csh' scripts from ideal case directories and modified the top-level Makefile so that now the files are linked during the compile. LIST OF MODIFIED FILES: M Makefile D test/em_b_wave/run_me_first.csh D test/em_convrad/run_me_first.csh D test/em_quarter_ss/run_me_first.csh D test/em_scm_xy/run_me_first.csh D test/em_seabreeze2d_x/run_me_first.csh D test/em_tropical_cyclone/run_me_first.csh TESTS CONDUCTED: 1. Ensured that code compiles and required files are linked for all modified ideal cases. 2. Jenkins is all pass. RELEASE NOTE: It is no longer necessary to execute a 'run_me_first.csh' script for any of the idealized cases. All necessary physics input files and look-up tables are linked to the corresponding directory during the compilation step.
TYPE: enhancement
KEYWORDS: ideal, run_me_first.csh, link, Makefile,
SOURCE: Internal
DESCRIPTION OF CHANGES:
Problem:
Several ideal cases (em_b_wave, em_convrad, em_quarter_ss, em_scm_xy, em_seabreeze2d_x, and em_tropical_cyclone)
need additional linked files to run. Previously it was necessary for users to run a script called 'run_me_first.csh' to
link-in the necessary files.
Solution:
Removed all 'run_me_first.csh' scripts from ideal case directories and modified the top-level Makefile so that now the
files are linked during the compile.
LIST OF MODIFIED FILES:
M Makefile
D test/em_b_wave/run_me_first.csh
D test/em_convrad/run_me_first.csh
D test/em_quarter_ss/run_me_first.csh
D test/em_scm_xy/run_me_first.csh
D test/em_seabreeze2d_x/run_me_first.csh
D test/em_tropical_cyclone/run_me_first.csh
TESTS CONDUCTED:
RELEASE NOTE: It is no longer necessary to execute a 'run_me_first.csh' script for any of the idealized cases. All necessary physics input files and look-up tables are linked to the corresponding directory during the compilation step.