Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix for radar_rf_opt=2 #1642

Merged
merged 1 commit into from
Jan 17, 2022
Merged

Bug fix for radar_rf_opt=2 #1642

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 9 additions & 20 deletions var/da/da_radar/da_get_innov_vector_radar.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ subroutine da_get_innov_vector_radar (it, grid, ob, iv)
qng=0
rn0_r=8e6
rn0_s=3e6
rn0_g=4e5
rn0_g=4e6
rhos=100.0
rhog=400.0
!------------------------
Expand Down Expand Up @@ -211,8 +211,8 @@ subroutine da_get_innov_vector_radar (it, grid, ob, iv)
call da_interp_lin_3d (grid%xb % wh, iv%info(radar), model_w)
call da_interp_lin_3d (grid%xb % rho, iv%info(radar), model_rho)
call da_interp_lin_3d (grid%xb % qrn, iv%info(radar), model_qrn)
call da_interp_lin_3d (grid%xb % qrn, iv%info(radar), model_qcl)
call da_interp_lin_3d (grid%xb % qrn, iv%info(radar), model_qci)
call da_interp_lin_3d (grid%xb % qcw, iv%info(radar), model_qcl)
call da_interp_lin_3d (grid%xb % qci, iv%info(radar), model_qci)
call da_interp_lin_3d (grid%xb % qsn, iv%info(radar), model_qsn)
IF ( ASSOCIATED( grid%xb%qgr ) ) THEN
call da_interp_lin_3d (grid%xb % qgr, iv%info(radar), model_qgr)
Expand Down Expand Up @@ -242,7 +242,7 @@ END IF

do n=iv%info(radar)%n1,iv%info(radar)%n2

if ( use_radar_rf ) then
if ( use_radar_rf .and. radar_rf_opt==1) then
! for Xiao's default scheme
! Test 5.0E-8 (kg/kg) as critical value. It can not be smaller.
do k=1,iv%info(radar)%levels(n)
Expand Down Expand Up @@ -367,9 +367,10 @@ END IF
end if

if (use_radar_rf .and. radar_rf_opt==2) then
iv % radar(n) % zmm(k) % inv = 0
iv % radar(n) % rf (k) % qc = -5 ! assume bad rf obs first
echo_rf_good = ob % radar(n) % rf(k) >= rfmin
if ( echo_rf_good ) then
!select case (radar_rf_opt)
!case(2)
tmk=model_tc(k,n)+273.15
prs=model_p(k,n)
zmm=0
Expand All @@ -380,20 +381,8 @@ END IF
0,zmm_ref)
model_rf(k,n)=dbz*radar_rf_rscl
iv % radar(n) % zmm(k) % inv = zmm
iv % radar(n) % rf(k) % inv = 0
if(ob % radar(n) % rf(k) < rfmin .and. ( model_qrn(k,n)<=2.0*rf_qthres.and. &
model_qsn(k,n)<=2.0*rf_qthres.and. &
model_qgr(k,n)<=2.0*rf_qthres)) then
iv % radar(n) % zmm(k) % inv = 0
iv % radar(n) % rf (k) % qc = -5
else if( ob % radar(n) % rf(k) < rfmin .and. ( model_qrn(k,n)>2.0*rf_qthres.or. &
model_qsn(k,n)>2.0*rf_qthres.or. &
model_qgr(k,n)>2.0*rf_qthres) ) then
iv % radar(n) % rf(k) % inv = rfmin - model_rf(k,n)
else if( ob % radar(n) % rf(k) >= rfmin ) then
iv % radar(n) % rf(k) % inv = ob % radar(n) % rf(k) - model_rf(k,n)
endif
!end select
iv % radar(n) % rf(k) % inv = ob % radar(n) % rf(k) - model_rf(k,n)
if (model_rf(k,n) >= rfmin) iv % radar(n) % rf (k) % qc = 0
end if
end if

Expand Down
14 changes: 1 addition & 13 deletions var/da/da_radar/da_radzicevar.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,6 @@ subroutine da_radzicevar(qvp0,qra0,qsn0,qgr0,qnr0,qns0,qng0,tmk0,prs,dbz,
integer :: temi01,temi02,temi03 ! temporary variable for integer

real :: para_pr,para_pdx_dq,para_pdx_df ! for
real :: tc

!---------------------------------------------------------------------------------

Expand Down Expand Up @@ -162,17 +161,6 @@ subroutine da_radzicevar(qvp0,qra0,qsn0,qgr0,qnr0,qns0,qng0,tmk0,prs,dbz,
! if(qsn0<qthres) qsn=qthres
! if(qgr0<qthres) qgr=qthres

tc=tmk-273.15
if(tc<=0.0) then
qra=max(qthres*(1+exp(-(tc-5.0)**2/6.25)),qra)
qsn=max(qthres*2,qsn)
qgr=max(qthres*2,qgr)
else
qra=max(qthres*2,qra)
qsn=max(qthres*(1+exp(-(tc-5.0)**2/6.25)),qsn)
qgr=max(qthres*(1+exp(-(tc-5.0)**2/6.25)),qgr)
endif

if(tlopt>=1.and.gropt>=1) then
dqra=0
dqgr=0
Expand Down Expand Up @@ -408,7 +396,7 @@ subroutine da_radzicevar(qvp0,qra0,qsn0,qgr0,qnr0,qns0,qng0,tmk0,prs,dbz,
! Convert to dBZ
!-------------------------------------
if(tlopt==0) then
dbz = max(-15.0,10. * log10(z_e))
dbz = 10. * log10(z_e)
endif
! save z_e mm^6 mm^-3
zmm=z_e
Expand Down
2 changes: 1 addition & 1 deletion var/da/da_radar/da_radzicevar_upper_f.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
if(flg==2) fmax=0.3 ! for hail/graupel

upper_f=0
if(qr>=qthres.and.qice>=qthres) then
if(qr>1.0e-12 .and. qice>1.0e-12) then
upper_f=fmax*min(qice/qr,qr/qice)**0.3
endif

Expand Down
2 changes: 1 addition & 1 deletion var/da/da_radar/da_transform_xtoy_radar.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ subroutine da_transform_xtoy_radar (grid, iv, y)
qng=0
rn0_r=8e6
rn0_s=3e6
rn0_g=4e5
rn0_g=4e6
rhos=100.0
rhog=400.0
!------------------------
Expand Down
2 changes: 1 addition & 1 deletion var/da/da_radar/da_transform_xtoy_radar_adj.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ subroutine da_transform_xtoy_radar_adj(grid, iv, jo_grad_y, jo_grad_x)
qng=0
rn0_r=8e6
rn0_s=3e6
rn0_g=4e5
rn0_g=4e6
rhos=100.0
rhog=400.0
!------------------------
Expand Down
2 changes: 1 addition & 1 deletion var/da/da_setup_structures/da_setup_obs_structures_radar.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ subroutine da_setup_obs_structures_radar( grid, ob, iv )

! Calculate DT for RF DA

if (use_radar_rf) then
if (use_radar_rf .and. radar_rf_opt==1) then
if (.not. DT_cloud_model) then
do j = jts,jte
do i = its, ite
Expand Down
2 changes: 1 addition & 1 deletion var/da/da_setup_structures/da_setup_structures.f90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ module da_setup_structures
analysis_date,coarse_ix,coarse_ds,map_projection,coarse_jy, c2,dsm,phic, &
pole, cone_factor, start_x,base_pres,ptop,psi1,start_y, base_lapse,base_temp,truelat2_3dv, &
truelat1_3dv,xlonc,t0,num_fft_factors,pi,print_detail_spectral, global, print_detail_obs, &
use_radar_rf, use_radar_rhv, use_radar_rqv, &
use_radar_rf, use_radar_rhv, use_radar_rqv, radar_rf_opt, &
num_ob_indexes,kts, kte, time_window_max, time_window_min, &
max_fgat_time, num_fgat_time, dt_cloud_model, &
use_ssmiretrievalobs,use_radarobs,use_ssmitbobs,use_qscatobs, num_procs, use_rainobs, &
Expand Down