coszen made not optional in Dudhia swrad #1675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weiwangncar
approved these changes
Feb 15, 2022
kkeene44
approved these changes
Mar 15, 2022
vlakshmanan-scala
pushed a commit
to scala-computing/WRF
that referenced
this pull request
Apr 4, 2024
TYPE: bug fix KEYWORDS: shortwave option 1, coszen not optional SOURCE: internal, reported by CWB, Taiwan DESCRIPTION OF CHANGES: Problem: Compiler picked up use of uninitialized eot. This was in the case of no coszen passed in which does not happen in ARW. Solution: coszen is no longer optional and branch for no coszen input is removed. LIST OF MODIFIED FILES: M phys/module_ra_sw.F TESTS CONDUCTED: Jenkins tests have passed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TYPE: bug fix
KEYWORDS: shortwave option 1, coszen not optional
SOURCE: internal, reported by CWB, Taiwan
DESCRIPTION OF CHANGES:
Problem:
Compiler picked up use of uninitialized eot. This was in the case of no coszen passed in which does not happen in ARW.
Solution:
coszen is no longer optional and branch for no coszen input is removed.
LIST OF MODIFIED FILES:
M phys/module_ra_sw.F
TESTS CONDUCTED:
RELEASE NOTE: