MP38 Thompson 2-mom graupel/hail (prev #1667) #1728
Conversation
|
Congratulations, Maria! The Jenkins tests have passed: |
|
Can you say what helped?
…On Fri, Apr 29, 2022 at 10:49 AM weiwangncar ***@***.***> wrote:
Congratulations, Maria! The Jenkins tests have passed:
Test Type | Expected | Received | Failed
= = = = = = = = = = = = = = = = = = = = = = = = = = = =
Number of Tests : 23 24
Number of Builds : 60 58
Number of Simulations : 158 156 0
Number of Comparisons : 95 92 0
Failed Simulations are:
None
Which comparisons are not bit-for-bit:
None
—
Reply to this email directly, view it on GitHub
<#1728 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEIZ77CTAK7HUE33BQPBCQLVHQHLLANCNFSM5UUAHFZQ>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
|
@gthompsnWRF Could you please review the proposed modification I made to the graupel table (5c47003..82edd98)? The jenkins test passed. Basically, when is_hail_aware is false, the loop I noticed that you hard-coded the 2nd dimension of cgg, and cge to 1 instead of n3 (throughout the code, not only in qr_acr_qg). I'm not sure if that's the intention or not. The other potential solution (i.e. separate the tables for mp28,8 and mp38) is quite a rabbit hole. I'd have to test is_hail_aware throughout the code because there are multiple max/min statements using NRHG or rho_g(NRHG), and I think it would become a mess very hard to untangle and prone to bugs.
|
|
@dudhia I reduced the graupel table computation to 1 dimension when mp=8 or 28. Then I copied the computed values to the remaining 8 elements that would represent the graupel variable-density in mp38. There's a more detailed explanation in my previous post to Greg. Please let me know if you have any questions. |
|
I see a risk there if someone runs 28 and then switches to 38, but it gets
us through the regtest which is a good thing.
…On Fri, Apr 29, 2022 at 11:19 AM Maria Frediani ***@***.***> wrote:
@dudhia <https://github.com/dudhia> I reduced the graupel table
computation to 1 dimension when mp=8 or 28. Then I copied the computed
values to the remaining 8 elements that would represent the graupel
variable-density in mp38. There's a more detailed explanation in my
previous post to Greg. Please let me know if you have any questions.
—
Reply to this email directly, view it on GitHub
<#1728 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEIZ77FWT4Q25YPC6UZEW2LVHQKZ7ANCNFSM5UUAHFZQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Good point @dudhia. I'll create distinct table names then. This is simple. |
This sounds like the best idea. A distinct table name for qr_acr_qg for each of the options is better by far. Thanks for doing this Maria!! |
|
@weiwangncar @dudhia I changed the table names to either qr_acr_qg_mp38V1.dat or qr_acr_qg_mp28V4.dat and tested it for mp38, mp28 and mp8. It's working as expected. Please let me know if anything else is needed for merging it with the develop branch. Thanks! |
|
Jenkins tests have passed for the last change: |
|
@mefrediani @gthompsnWRF Thanks for making these changes to allow regression tests to pass. Do you have any suggestions how we will go about creating the table for double moment graupel/hail? It still takes a very long time when people first choose the option. |
|
@weiwangncar Could we add another item and a link to download it on this page: https://www2.mmm.ucar.edu/wrf/users/download/get_source.html ? |
|
@mefrediani That could be a solution. |
|
@weiwangncar do you need anything else from me in order to approve the merge? Do you want to add the table on the webpage asap or later when approaching the next major release? |
|
@mefrediani I don't have concern as of now. If you have the computed tables for the new option, you can pass them to us. We probably won't need them until the next release, but we can keep them on Cheyenne. The reg tests won't test the new option, so I assume you have, with the renamed tables? |
|
@mefrediani could you update the PR message to include what was done with the table? I wonder if we also need a manual bit-for-bit test with the new option since it is not in the regtest. |
phys/module_microphysics_driver.F
Outdated
| ENDIF | ||
| ! | ||
| CASE (THOMPSONGH) | ||
| CALL wrf_debug ( 100 , 'microphysics_driver: calling thompson' ) |
|
I should have one more look at the code changes just to double-check a few things. Thanks Maria for doing this!!! |
@gthompsnWRF were you able to do the final checks in the code? |
|
Or you could dummy values that are easy to detect on those filled areas.
…On Fri, Apr 29, 2022 at 11:33 AM Maria Frediani ***@***.***> wrote:
Good point @dudhia <https://github.com/dudhia>. I'll create distinct
table names then. This is simple.
—
Reply to this email directly, view it on GitHub
<#1728 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEIZ77CNCOYNBBZD6WOJW5TVHQMP7ANCNFSM5UUAHFZQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@dudhia This didn't work. When I push it, Git gives me an error: |
|
OK, interesting that there is a limit. We'll see what the test does. Will other Thompson options also try to use that big table? Because those will be in the automatic tests. |
|
@kkeene44 I think I broke my remote branch. I used the web interface to sync with the fork and somehow it synced with master. Do i need to create a new PR to fix this? |
@dudhia No, the big table (qr_acr_qg_mp38V1.dat) is only needed for MP38. There's a different table for MP28 and MP8 (qr_acr_qg_mp28V4.dat). |
|
@mefrediani This is for future reference: there is never a need to merge with updated branch or even the master branch for an existing PR. The git software will check for any conflict and warn and/block if we try to merge. Any conflicts found at that point will require fixes. Let's wait and retry your code after we resolve reg test issues. |
|
@weiwangncar thanks for the clarification. I'll remember that in the future. In my other PR (1801), Jimy mentioned you're having issues with the reg tests, so I'll hang on for now and wait for someone to tell me if there's anything else I can do. |
chem/depend.chem
Outdated
| @@ -229,7 +229,7 @@ module_mosaic_sect_intr.o: module_mosaic_coag1d.o module_mosaic_coag3d.o module_ | |||
|
|
|||
| module_mosaic_aerdynam_intr.o: module_mosaic_sect_intr.o module_mosaic_aerchem_intr.o | |||
|
|
|||
| module_mosaic_addemiss.o: module_data_mosaic_asect.o module_data_sorgam.o | |||
| module_mosaic_addemiss.o: module_data_mosaic_asect.o module_data_sorgam.o module_gocart_dust.o | |||
There was a problem hiding this comment.
wondering why gocart is added here
inc/version_decl
Outdated
| @@ -1 +1 @@ | |||
| CHARACTER (LEN=*), PARAMETER :: release_version = 'V4.4' | |||
| CHARACTER (LEN=*), PARAMETER :: release_version = 'V4.4.2' | |||
There was a problem hiding this comment.
this needs updating to V4.5
run/VEGPARM.TBL
Outdated
| LCZ_11 | ||
| 41 | ||
| 61 |
There was a problem hiding this comment.
These changes seem to indicate some inconsistency in branches because they should already be in
|
@mefrediani could you resubmit this PR to see if it resolves the issue of seeing unrelated updates in the git differences for files changed? |
I don't think simply re-submitting the PR with the same branch is going to be a solution. I'll take a look through the branch history today and suggest a suitable rebase of the current PR branch. |
|
@mefrediani I think most of the issues that @weiwangncar and @dudhia are concerned about originate from the merge of the If you have any questions about the rebase process, just let me know and I'll be glad to help. |
… (default false) and error message when table is not present
|
Much better. Thanks.
…On Mon, Jan 16, 2023 at 11:37 AM Maria Frediani ***@***.***> wrote:
@mgduda <https://github.com/mgduda> thank you so much for your help with
the rebase. I think it worked. I had to create a new PR because after
rebasing, the branch was not fast-forwardable. The new PR is #1808
<#1808>.
—
Reply to this email directly, view it on GitHub
<#1728 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEIZ77G52I6DUVT5HFYRLZLWSWIPHANCNFSM5UUAHFZQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@mgduda When I tried to push it, I got this message: |
For future reference, you can just use |
|
@mefrediani If your branch still exists, you can give Michael's suggestion a try. It won't change anything but your branch on the Github. We will later close this PR. |
|
@weiwangncar I'd like to try it but Cheyenne/Glade is offline this week. Can you wait until next to close this PR? |
We can certainly do that. There is no hurry to close a PR. |
|
@mgduda @weiwangncar Michael's suggestion worked! Thank you! |
Option to compute two-moment prognostics for graupel/hail TYPE: enhancement, new feature KEYWORDS: microphysics, Thompson microphysics, graupel, hail, double-moment SOURCE: Code developed by Greg Thompson (JCSDA, UCAR) and Anders Jensen (RAL, NCAR). Implemented in WRF v4.4 by Maria Frediani (RAL, NCAR) DESCRIPTION OF CHANGES: This code update includes a package to compute two-moment prognostics for graupel/hail and a predicted density graupel category (mp_physics=38); an update to the Y-intercept relationship for one-moment graupel; and it replaces air temperature for wet-bulb temperature in riming and mixed phase processes. Problem: One-dimensional graupel/hail growth does not couple to the storm dynamics and is insufficient for predicting more detailed microphysical storm characteristics and hazards such as hail size, density, and fall speed, which can be used to provide guidance on the timing and spatial extent of damaging hail. Sensitivity studies have shown that using a constant intercept parameter and a constant density can significantly constrain predicted hail size: simulated storms either produced only pea-size or baseball-size hail (Gilmore et al. 2004). Improving the representation of riming and mixed phase processes leads to improvements in predicted storm dynamics and propagation speed through microphysical feedbacks and also improves the spatial distribution and type of precipitation at the surface. Solution: Changes related with the new package mp_physics=38 include: Variable density for graupel (rho_g) Parameters become a function of rho_g (am_g, av_g, bv_g, cge, cgg, oamg) Extra dimension in lookup tables to account for graupel variable density (rho_g) New source/sink terms for 3-moment graupel Computation of radar reflectivity and nwp diagnostics using graupel volume mixing ratio Additional modifications affecting mp_physics=8 and mp_physics=28 include: Fall speed power law relations (av_i from 1847.5 to 1493.9) Reduced dimension of cse, csg (from 18 to 17) Use of wet-bulb temperature for riming and mixed-phase process Modified relationship for the Y-intercept of one-moment graupel to shift the properties of the graupel category to become more hail-like, resulting in a category that represents both graupel and hail. LIST OF MODIFIED FILES: M Registry/Registry.EM_COMMON M phys/module_diag_nwp.F M phys/module_diagnostics_driver.F M phys/module_microphysics_driver.F M phys/module_mp_thompson.F M phys/module_physics_init.F TESTS CONDUCTED: 1. The modifications were initially demonstrated using the original development made for WRF v4.0 (Jensen et al 2021, under review, MWR-D-21-0319). The operational mp28, mp28 with modified graupel Y-intercept, and mp38 were evaluated for a case study during the PECAN campaign using observed hail sizes from storm reports and estimated from radar. The evaluation showed clear improvement of the simulated reflectivity values in the upper-levels of discrete storms, coinciding with a significant reduction in the areal extent of graupel aloft, also seen when using the updated one-moment scheme. The two-moment and predicted density graupel scheme was also better able to predict a wide variety of hail sizes at the surface, including large (>2-inch in diameter) hail that was observed during this case. The implementation for this develop branch (aiming at the release v4.4) was tested using a case study from the Relampago campaign and results from mp28, mp38-v4.0, mp38-develop-v4.4 were compared. This comparison indicates that the implementation was successful. 2. It passed regression tests. RELEASE NOTES: A package to compute two-moment prognostics for graupel/hail and a predicted density graupel category is added in the Thompson scheme (mp_physics=38); Other updates to the scheme include a change to the Y-intercept relationship for one-moment graupel; and replacement of air temperature for wet-bulb temperature in riming and mixed phase processes. The code requires a data file to run. This data file: qr_acr_qg_mp38V1.dat can be found on NCAR's computer under /glade/work/wrfhelp/WRF_files/, and online at http://www2.mmm.ucar.edu/wrf/src/wrf_files/. If you prefer to compute this file, set namelist write_thompson_mp38table = true. Note that it can take up to 18 min to compute this table using a 12-CPU job, 4 min on 128-CPU, and several hours if computed on a single CPU.
|
Superseded by #1808 |
wrf-model#1808) Option to compute two-moment prognostics for graupel/hail TYPE: enhancement, new feature KEYWORDS: microphysics, Thompson microphysics, graupel, hail, double-moment SOURCE: Code developed by Greg Thompson (JCSDA, UCAR) and Anders Jensen (RAL, NCAR). Implemented in WRF v4.4 by Maria Frediani (RAL, NCAR) DESCRIPTION OF CHANGES: This code update includes a package to compute two-moment prognostics for graupel/hail and a predicted density graupel category (mp_physics=38); an update to the Y-intercept relationship for one-moment graupel; and it replaces air temperature for wet-bulb temperature in riming and mixed phase processes. Problem: One-dimensional graupel/hail growth does not couple to the storm dynamics and is insufficient for predicting more detailed microphysical storm characteristics and hazards such as hail size, density, and fall speed, which can be used to provide guidance on the timing and spatial extent of damaging hail. Sensitivity studies have shown that using a constant intercept parameter and a constant density can significantly constrain predicted hail size: simulated storms either produced only pea-size or baseball-size hail (Gilmore et al. 2004). Improving the representation of riming and mixed phase processes leads to improvements in predicted storm dynamics and propagation speed through microphysical feedbacks and also improves the spatial distribution and type of precipitation at the surface. Solution: Changes related with the new package mp_physics=38 include: Variable density for graupel (rho_g) Parameters become a function of rho_g (am_g, av_g, bv_g, cge, cgg, oamg) Extra dimension in lookup tables to account for graupel variable density (rho_g) New source/sink terms for 3-moment graupel Computation of radar reflectivity and nwp diagnostics using graupel volume mixing ratio Additional modifications affecting mp_physics=8 and mp_physics=28 include: Fall speed power law relations (av_i from 1847.5 to 1493.9) Reduced dimension of cse, csg (from 18 to 17) Use of wet-bulb temperature for riming and mixed-phase process Modified relationship for the Y-intercept of one-moment graupel to shift the properties of the graupel category to become more hail-like, resulting in a category that represents both graupel and hail. LIST OF MODIFIED FILES: M Registry/Registry.EM_COMMON M phys/module_diag_nwp.F M phys/module_diagnostics_driver.F M phys/module_microphysics_driver.F M phys/module_mp_thompson.F M phys/module_physics_init.F TESTS CONDUCTED: 1. The modifications were initially demonstrated using the original development made for WRF v4.0 (Jensen et al 2021, under review, MWR-D-21-0319). The operational mp28, mp28 with modified graupel Y-intercept, and mp38 were evaluated for a case study during the PECAN campaign using observed hail sizes from storm reports and estimated from radar. The evaluation showed clear improvement of the simulated reflectivity values in the upper-levels of discrete storms, coinciding with a significant reduction in the areal extent of graupel aloft, also seen when using the updated one-moment scheme. The two-moment and predicted density graupel scheme was also better able to predict a wide variety of hail sizes at the surface, including large (>2-inch in diameter) hail that was observed during this case. The implementation for this develop branch (aiming at the release v4.4) was tested using a case study from the Relampago campaign and results from mp28, mp38-v4.0, mp38-develop-v4.4 were compared. This comparison indicates that the implementation was successful. 2. It passed regression tests. RELEASE NOTES: A package to compute two-moment prognostics for graupel/hail and a predicted density graupel category is added in the Thompson scheme (mp_physics=38); Other updates to the scheme include a change to the Y-intercept relationship for one-moment graupel; and replacement of air temperature for wet-bulb temperature in riming and mixed phase processes. The code requires a data file to run. This data file: qr_acr_qg_mp38V1.dat can be found on NCAR's computer under /glade/work/wrfhelp/WRF_files/, and online at http://www2.mmm.ucar.edu/wrf/src/wrf_files/. If you prefer to compute this file, set namelist write_thompson_mp38table = true. Note that it can take up to 18 min to compute this table using a 12-CPU job, 4 min on 128-CPU, and several hours if computed on a single CPU.
Option to compute two-moment prognostics for graupel/hail
TYPE: enhancement, new feature
KEYWORDS: microphysics, Thompson microphysics, graupel, hail, double-moment
SOURCE: Code developed by Greg Thompson (JCSDA, UCAR) and Anders Jensen (RAL, NCAR).
Implemented in WRF v4.4 by Maria Frediani (RAL, NCAR)
DESCRIPTION OF CHANGES:
This code update includes
a package to compute two-moment prognostics for graupel/hail and a predicted density graupel category (mp_physics=38);
an update to the Y-intercept relationship for one-moment graupel; and
it replaces air temperature for wet-bulb temperature in riming and mixed phase processes.
Problem:
One-dimensional graupel/hail growth does not couple to the storm dynamics and is insufficient for predicting more detailed microphysical storm characteristics and hazards such as hail size, density, and fall speed, which can be used to provide guidance on the timing and spatial extent of damaging hail.
Sensitivity studies have shown that using a constant intercept parameter and a constant density can significantly constrain predicted hail size: simulated storms either produced only pea-size or baseball-size hail (Gilmore et al. 2004).
Improving the representation of riming and mixed phase processes leads to improvements in predicted storm dynamics and propagation speed through microphysical feedbacks and also improves the spatial distribution and type of precipitation at the surface.
Solution:
Changes related with the new package mp_physics=38 include:
Variable density for graupel (rho_g)
Parameters become a function of rho_g (am_g, av_g, bv_g, cge, cgg, oamg)
Extra dimension in lookup tables to account for graupel variable density (rho_g)
New source/sink terms for 3-moment graupel
Computation of radar reflectivity and nwp diagnostics using graupel volume mixing ratio
Additional modifications affecting mp_physics=8 and mp_physics=28 include:
Fall speed power law relations (av_i from 1847.5 to 1493.9)
Reduced dimension of cse, csg (from 18 to 17)
Use of wet-bulb temperature for riming and mixed-phase process
Modified relationship for the Y-intercept of one-moment graupel to shift the properties of the graupel category to become more hail-like, resulting in a category that represents both graupel and hail.
ISSUE: NA
LIST OF MODIFIED FILES:
M Registry/Registry.EM_COMMON
M phys/module_diag_nwp.F
M phys/module_diagnostics_driver.F
M phys/module_microphysics_driver.F
M phys/module_mp_thompson.F
M phys/module_physics_init.F
TESTS CONDUCTED:
The modifications were initially demonstrated using the original development made for WRF v4.0 (Jensen et al 2021, under review, MWR-D-21-0319). The operational mp28, mp28 with modified graupel Y-intercept, and mp38 were evaluated for a case study during the PECAN campaign using observed hail sizes from storm reports and estimated from radar. The evaluation showed clear improvement of the simulated reflectivity values in the upper-levels of discrete storms, coinciding with a significant reduction in the areal extent of graupel aloft, also seen when using the updated one-moment scheme. The two-moment and predicted density graupel scheme was also better able to predict a wide variety of hail sizes at the surface, including large (>2-inch in diameter) hail that was observed during this case.
The implementation for this develop branch (aiming at the release v4.4) was tested using a case study from the Relampago campaign and results from mp28, mp38-v4.0, mp38-develop-v4.4 were compared. This comparison indicates that the implementation was successful.
RELEASE NOTE: Include a stand-alone message suitable for the inclusion in the minor and annual releases. A publication citation is appropriate.