Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check if WRF_CMAQ is empty first #1744

Merged
merged 1 commit into from
Feb 9, 2023
Merged

check if WRF_CMAQ is empty first #1744

merged 1 commit into from
Feb 9, 2023

Conversation

wkliao
Copy link
Contributor

@wkliao wkliao commented Jun 18, 2022 •
edited by weiwangncar
Loading

TYPE: bug fix

KEYWORDS: Makefile, string check

SOURCE:

Problem:
When WRF_CMAQ is empty, it spews the following error message.

/bin/sh: line 0: [: -eq: unary operator expected

Solution:
Check if WRF_CMAQ is empty first.

Modified files:
M Makefile

TESTS CONDUCTED:

  • Yes, the change fixes the error.
  • The Jenkins tests have passed. No effect on other code.

RELEASE NOTE:

@wkliao wkliao requested a review from a team as a code owner June 18, 2022 19:23
@dudhia
Copy link
Collaborator

dudhia commented Aug 3, 2022

Note target is master

@weiwangncar weiwangncar changed the base branch from master to release-v4.4.1 August 3, 2022 16:36
dudhia
dudhia reviewed Jan 5, 2023
View reviewed changes
Copy link
Collaborator

@dudhia dudhia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will add to develop if people think it is safe

@dudhia dudhia changed the base branch from release-v4.4.1 to develop January 12, 2023 16:27
@weiwangncar
Copy link
Collaborator

@wkliao Can you refer to other PR and use the template to create a PR?
@dwongepa Can you review this PR?

@dwongepa
Copy link
Contributor

dwongepa commented Feb 3, 2023

The suggested change is fine. Approve.

@weiwangncar
Copy link
Collaborator

@wkliao Can you edit the PR message to be like others? Thanks.

@mgduda mgduda changed the base branch from develop to release-v4.5 February 7, 2023 02:14
@dwongepa
Copy link
Contributor

dwongepa commented Feb 7, 2023

@wkliao Thank you for finding this issue and provided a fix. I have tested and it works.
@weisunncar I approve this PR.

@mgduda mgduda self-requested a review February 7, 2023 17:33
@weiwangncar weiwangncar merged commit 6211855 into wrf-model:release-v4.5 Feb 9, 2023
@wkliao wkliao deleted the WRF_CMAQ branch December 9, 2023 17:59
vlakshmanan-scala pushed a commit to scala-computing/WRF that referenced this pull request Apr 4, 2024
@wkliao @vlakshmanan-scala
check if WRF_CMAQ is empty first (wrf-model#1744)
4e4d403 
TYPE: bug fix

KEYWORDS: Makefile, string check

SOURCE:

Problem:
When WRF_CMAQ is empty, it spews the following error message.
/bin/sh: line 0: [: -eq: unary operator expected

Solution:
Check if WRF_CMAQ is empty first.

Modified files:
M Makefile

TESTS CONDUCTED:

Yes, the change fixes the error.
The Jenkins tests have passed. No effect on other code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dudhia dudhia dudhia left review comments

@smileMchen smileMchen smileMchen approved these changes

@mgduda mgduda mgduda approved these changes

Assignees
No one assigned
Labels
Develop Branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@wkliao @dudhia @weiwangncar @dwongepa @mgduda @smileMchen