NoahMP bug fix for crop unit and LCZ urban grid identification #1779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The regtests have passed: |
|
Will this PR be approved soon? I have another bug fix for LCZ, which involves changes for Noah and Noah-MP so I have to wait until this Noah-MP PR is merged to make new PR changes. Thanks! |
|
OK, I can approve it now. |
dudhia
approved these changes
Nov 17, 2022
weiwangncar
approved these changes
Nov 18, 2022
vlakshmanan-scala
pushed a commit
to scala-computing/WRF
that referenced
this pull request
Apr 4, 2024
NoahMP bug fix for crop unit and LCZ urban grid identification TYPE: bug fix KEYWORDS: NoahMP crop, unit conversion, LCZ urban SOURCE: Cenlin He (NCAR) DESCRIPTION OF CHANGES: 1. A bug was identified in the NoahMP crop and carbon schemes (carbon and carbon_crop subroutines in module_sf_noahmplsm.F) diagnostic variable unit conversion and has been fixed in this PR; This fix is no-answer change because these diagnostic variables are not passed to WRF outputs. 2. Urban pixel identification is updated by including LCZ urban types in addition to the default MODIS/USGS urban type in module_sf_noahmpdrv.F for surface variable initialization. LIST OF MODIFIED FILES: list of changed files: M phys/noahmp TESTS CONDUCTED: 1. tested successfully in NCAR Cheyenne HPC 2. reg tests have passed. RELEASE NOTE: This PR fixes a few variable unit conversion in subroutine CARBON and CARBON_CROP subroutines, and urban grid identification by including LCZ urban types for variable initialization.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NoahMP bug fix for crop unit and LCZ urban grid identification
TYPE: bug fix
KEYWORDS: NoahMP crop, unit conversion, LCZ urban
SOURCE: Cenlin He (NCAR)
DESCRIPTION OF CHANGES:
LIST OF MODIFIED FILES: list of changed files:
M phys/noahmp
TESTS CONDUCTED:
RELEASE NOTE: This PR fixes a few variable unit conversion in subroutine CARBON and CARBON_CROP subroutines, and urban grid identification by including LCZ urban types for variable initialization.