Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix for building height in LCZ urban parameter table #1867

Merged
merged 12 commits into from
Jul 5, 2023

Conversation

cenlinhe
Copy link
Contributor

Bug fix for building height in LCZ urban parameter table

TYPE: bug fix

KEYWORDS: urban, BEP, BEP_BEM, parameter table, building height

SOURCE: Cenlin He (NCAR), Alberto Martilli (CIEMAT, Spain)

DESCRIPTION OF CHANGES:
Problem:
The BEP and BEP_BEM urban schemes (urban_physics = 2,3) require the building height distribution to be a multiple of 5-m because of the hard-coded dz_u = 5 parameter in BEP and BEP_BEM source code. However, currently the urban parameter table (URBPARM_LCZ.TBL) has a building height distribution as a multiple of 3-m, which will cause model issues.

Solution:
Change the building height distribution in URBPARM_LCZ.TBL to be a multiple of 5-m. In addition to the model code requirement as mentioned above, the justifications of this change also include: (1) the NUDAPT database has building heights as a multiple of 5m. (2) the updated mean building heights in URBPARM_LCZ.TBL aer equal to the middle range values of the urban LCZs from Stewart and Oke (2012): Stewart, I. D., & Oke, T. R. (2012). Local climate zones for urban temperature studies. Bulletin of the American Meteorological Society, 93(12), 1879-1900.

LIST OF MODIFIED FILES:
run/URBPARM_LCZ.TBL

TESTS CONDUCTED:

  1. The mods fixed the problem.

RELEASE NOTE: This is a bug fix for building height in LCZ urban parameter table

@cenlinhe cenlinhe requested a review from a team as a code owner May 13, 2023 21:31
@weiwangncar
Copy link
Collaborator

The regression test results:

Test Type              | Expected  | Received |  Failed
= = = = = = = = = = = = = = = = = = = = = = = =  = = = =
Number of Tests        : 23           24
Number of Builds       : 60           57
Number of Simulations  : 158           150        0
Number of Comparisons  : 95           86        0

Failed Simulations are: 
None
Which comparisons are not bit-for-bit: 
None

@cenlinhe
Copy link
Contributor Author

cenlinhe commented Jun 6, 2023

I believe the previous values are from a specific study by Andrea Zonato. Now, we are updating these values based on the the middle-range global mean values of the urban LCZs from Stewart and Oke (2012), which is more applicable for future studies as suggested by Alberto Martilli.

@weiwangncar
Copy link
Collaborator

@cenlinhe Do you want this to be in 4.5.1?

@cenlinhe
Copy link
Contributor Author

cenlinhe commented Jun 9, 2023

Yes, we want to include this bug fix as soon as possible.

@weiwangncar weiwangncar changed the base branch from develop to release-v4.5.1 June 9, 2023 16:24
@weiwangncar weiwangncar merged commit fb4be8f into wrf-model:release-v4.5.1 Jul 5, 2023
vlakshmanan-scala pushed a commit to scala-computing/WRF that referenced this pull request Apr 4, 2024
)

Bug fix for building height in LCZ urban parameter table

TYPE: bug fix

KEYWORDS: urban, BEP, BEP_BEM, parameter table, building height

SOURCE: Cenlin He (NCAR), Alberto Martilli (CIEMAT, Spain)

DESCRIPTION OF CHANGES:
Problem:
The BEP and BEP_BEM urban schemes (urban_physics = 2,3) require the building height distribution to be a multiple of 5-m because of the hard-coded dz_u = 5 parameter in BEP and BEP_BEM source code. However, currently the urban parameter table (URBPARM_LCZ.TBL) has a building height distribution as a multiple of 3-m, which will cause model issues.

Solution:
Change the building height distribution in URBPARM_LCZ.TBL to be a multiple of 5-m. In addition to the model code requirement as mentioned above, the justifications of this change also include: (1) the NUDAPT database has building heights as a multiple of 5m. (2) the updated mean building heights in URBPARM_LCZ.TBL aer equal to the middle range values of the urban LCZs from Stewart and Oke (2012): Stewart, I. D., & Oke, T. R. (2012). Local climate zones for urban temperature studies. Bulletin of the American Meteorological Society, 93(12), 1879-1900.

LIST OF MODIFIED FILES:
run/URBPARM_LCZ.TBL

TESTS CONDUCTED:
The regression tests have passed.

The mods fixed the problem.
RELEASE NOTE: This is a bug fix for building height in LCZ urban parameter table.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants