Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing how Config.pl looks for the HDF5 high-level fortran library. #1934

Merged
merged 2 commits into from
Dec 10, 2023

Conversation

t-brown
Copy link
Contributor

@t-brown t-brown commented Nov 8, 2023

Changing how Config.pl looks for the HDF5 high-level fortran library.

TYPE: enhancement
KEYWORDS: HDF5, high-level, fortran, library

SOURCE: Timothy Brown (AWS)

DESCRIPTION OF CHANGES:
Problem:
Depending on the installation type (autotools or cmake) of HDF5 the high-level fortran library can be either hdf5_hl_fortran or hdf5hl_fortran.

Solution:
In Config.pl we now check the HDF5 library directory for the high-level fortran library.

ISSUE:
Fixes manual WRF build with Spack

LIST OF MODIFIED FILES:

  • arch/Config.pl

TESTS CONDUCTED:

  1. Yes. I have configured and built WRF against installs of HDF5 where the high-level fortran library has been
    a. hdf5_hl_fortran
    b. hdf5hl_fortran
    c. hdf5_hl_fortran and hdf5hl_fortran
  2. Passed the Jenkins tests.

RELEASE NOTE: Config.pl now tests for the HDF5 high-level fortran library.

@t-brown t-brown requested a review from a team as a code owner November 8, 2023 14:49
@weiwangncar weiwangncar changed the base branch from master to release-v4.5.2 November 10, 2023 02:37
@weiwangncar
Copy link
Collaborator

The regression test results:

Test Type              | Expected  | Received |  Failed
= = = = = = = = = = = = = = = = = = = = = = = =  = = = =
Number of Tests        : 23           24
Number of Builds       : 60           57
Number of Simulations  : 158           150        0
Number of Comparisons  : 95           86        0

Failed Simulations are: 
None
Which comparisons are not bit-for-bit: 
None

@weiwangncar weiwangncar merged commit d69761a into wrf-model:release-v4.5.2 Dec 10, 2023
1 of 2 checks passed
@smileMchen
Copy link
Collaborator

@t-brown
Please confirm that the following release note for this PR is correct:
The fortran library can be either hdf5_hl_fortran or hdf5hl_fortran for HDF5, which is now checked in Config.pl.

@t-brown
Copy link
Contributor Author

t-brown commented Dec 18, 2023

Yeap, that's fine. Thanks.

@smileMchen
Copy link
Collaborator

@t-brown
Hi, Timothy
Thank you for the confirmation.

vlakshmanan-scala pushed a commit to scala-computing/WRF that referenced this pull request Apr 4, 2024
…wrf-model#1934)

Changing how Config.pl looks for the HDF5 high-level fortran library.

TYPE: enhancement
KEYWORDS: HDF5, high-level, fortran, library

SOURCE: Timothy Brown (AWS)

DESCRIPTION OF CHANGES:
Problem:
Depending on the installation type (autotools or cmake) of HDF5 the high-level fortran library can be either `hdf5_hl_fortran` or `hdf5hl_fortran`.

Solution:
In `Config.pl` we now check the HDF5 library directory for the high-level fortran library.

ISSUE:
Fixes [manual WRF build with Spack](aws-samples/aws-hpc-tutorials#452)

LIST OF MODIFIED FILES:
M      arch/Config.pl

TESTS CONDUCTED:
1. Yes. I have configured and built WRF against installs of HDF5 where the high-level fortran library has been
    a. hdf5_hl_fortran
    b. hdf5hl_fortran
    c. hdf5_hl_fortran and hdf5hl_fortran
2. Passed the Jenkins tests.

RELEASE NOTE: Config.pl now tests for the HDF5 high-level fortran library.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Manual install of WRF failing, missing wrong library (solved, just FYI)
4 participants