Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Resubmit for PR #1881] New option for SLUCM to use global distributed urban aerodynamic parameters #1986
[Resubmit for PR #1881] New option for SLUCM to use global distributed urban aerodynamic parameters #1986
Changes from all commits
45d1380
c8d86d3
3d62e5e
08e71b9
4bc9b99
26e33d9
63902b4
bcf4941
2ab4941
6cfb6e8
cfad9e0
4154469
5732c24
6ff203f
7cacbfd
05d23af
8541190
b2dfab8
3c1b440
95c78b4
9141bf5
448067e
c27eece
56ca486
8aae62b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cenlinhe I don't understand
package
in Registry very well but should we add here something likeso that those who don't use AH won't need to allocate a big array?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is fine for now to package it to SLUCM scheme. Later, we can create a new package if needed. Currently, there is limited time to finalize the code for the upcoming WRF release, so I do not suggest any major changes unless it is necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cenlinhe Thank you. I understand.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
urban fraction set to annual mean vegetation fraction?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I asked the same question to the developer and he said this treatment seems most reasonable for their new scheme.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would be concerned about urban areas in dry/desert regions. Why not trust frc_urb2d more?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dudhia
@cenlinhe If time is limited, can we let it be a TODO for the next minor WRF release?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can think of it later
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@epn09 @cenlinhe Why is HFX added at the end of PBL driver? What is the added HFX for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is for anthropogenic heat flux (i.e., sensible heat flux) released from surface human activities to the atmosphere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cenlinhe After the PBL call, how do you expect the flux to be affecting the atmosphere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think @epn09 originally wants to let this flux affect atmosphere for the next time step. Another technical consideration is that @epn09 wants to add this flux to the temperature tendency (distributed_ahe_opt=1) which is an output of PBL scheme (if I understand it correctly), so this part needs to be added at the end of PBL call. This is my understanding.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@weiwangncar @cenlinhe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@epn09 It could explain why your added HFX doesn't have much effect to the model. The flux will be re-computed in the model's next step in the land model, which is called second after the radiation and before PBL.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@weiwangncar I see. So where would be the right place to add AH to HFX?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@epn09 Perhaps you could do this in module_pbl_driver.F, but before any PBL physics is called.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some PBL schemes may set RTHBLTEN to zero before adding to it. It needs to be checked.