Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unsupported -auto icx flag from Intel oneAPI stanza #2059

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

islas
Copy link
Collaborator

@islas islas commented Jun 7, 2024

TYPE: bug fix

KEYWORDS: intel, compilation, oneapi

SOURCE: internal

DESCRIPTION OF CHANGES:
Problem:
The -auto flag is not supported by the Intel C compilers. See https://www.intel.com/content/www/us/en/docs/cpp-compiler/developer-guide-reference/2021-10/alphabetical-option-list.html for full list of supported icx flags.

Solution:
Remove the flag, no output changes should happen as the flag was previously being ignored if it didn't cause an error.

@islas islas requested a review from a team as a code owner June 7, 2024 18:48
@weiwangncar
Copy link
Collaborator

The regression test results:

Test Type              | Expected  | Received |  Failed
= = = = = = = = = = = = = = = = = = = = = = = =  = = = =
Number of Tests        : 23           24
Number of Builds       : 60           57
Number of Simulations  : 158           150        0
Number of Comparisons  : 95           86        0

Failed Simulations are: 
None
Which comparisons are not bit-for-bit: 
None

@weiwangncar
Copy link
Collaborator

@islas For an older version of Intel C compiler, would removing -auto cause any trouble?

@islas
Copy link
Collaborator Author

islas commented Aug 7, 2024

@weiwangncar I can't find any reference to -auto being part of the icc compiler, so I suspect removing it would have no impact. Also, on Derecho I get this warning as well :
icc: command line warning #10006: ignoring unknown option '-auto'

@mgduda mgduda self-requested a review September 11, 2024 21:01
Copy link
Collaborator

@mgduda mgduda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that the icx compiler rejects the -auto option:

icx: error: unknown argument: '-auto'

@islas islas merged commit a6056c1 into wrf-model:release-v4.6.1 Sep 11, 2024
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants