check eta levels in ideal case #955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davegill
reviewed
Jul 22, 2019
dyn_em/module_initialize_ideal.F
Outdated
| @@ -631,6 +631,19 @@ SUBROUTINE init_domain_rk ( grid & | |||
| DO k=1, kde | |||
| grid%znw(k) = model_config_rec%eta_levels(k) | |||
| ENDDO | |||
| !Check the value of the first and last eta level for our domain, | |||
There was a problem hiding this comment.
@dudhia
Jimy,
Would you indent this so that it lines up with the rest of the code.
There was a problem hiding this comment.
I am OK with this PR now.
Just for conventional look to comments in the module_initialize_ideal.F file.
davegill
pushed a commit
that referenced
this pull request
Jan 25, 2022
Modify description for GWD input fields TYPE: text only KEYWORDS: field description, registry, gwdo SOURCE: internal DESCRIPTION OF CHANGES: Problem: Descriptions for GWDO input fields are not clear, and some is even wrong in the registry. Solution: This PR modifies the descriptions for all 10 GWDO input variables: VAR,CON,OA[1-4],OL[1-4], and made them consistent with MPAS PR[#955](MPAS-Dev/MPAS-Model#955). LIST OF MODIFIED FILES: M Registry/Registry.EM_COMMON TESTS CONDUCTED: 1. Descriptions changed. 2. Are the Jenkins tests all passing? RELEASE NOTE: Description for the 10 orographic gravity wave drag variables (gwd_opt=1 only) are updated.
vlakshmanan-scala
pushed a commit
to scala-computing/WRF
that referenced
this pull request
Apr 4, 2024
Modify description for GWD input fields TYPE: text only KEYWORDS: field description, registry, gwdo SOURCE: internal DESCRIPTION OF CHANGES: Problem: Descriptions for GWDO input fields are not clear, and some is even wrong in the registry. Solution: This PR modifies the descriptions for all 10 GWDO input variables: VAR,CON,OA[1-4],OL[1-4], and made them consistent with MPAS PR[wrf-model#955](MPAS-Dev/MPAS-Model#955). LIST OF MODIFIED FILES: M Registry/Registry.EM_COMMON TESTS CONDUCTED: 1. Descriptions changed. 2. Are the Jenkins tests all passing? RELEASE NOTE: Description for the 10 orographic gravity wave drag variables (gwd_opt=1 only) are updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TYPE: enhancement
KEYWORDS: ideal, eta
SOURCE: internal
DESCRIPTION OF CHANGES:
CPreviously, no check existed to detect invalid eta levels that a user specified in the
namelist.inputfile for an idealized case. A couple loops of code were copied from the file
dyn_em/module_initialize-real.F, which is used in the real program.LIST OF MODIFIED FILES:
M dyn_em/module_initialize_ideal.F
TESTS CONDUCTED:
RELEASE NOTE:
If a user chooses to explicitly list the eta levels for an idealized case, a check has been added to verify that valid eta levels are supplied for idealized cases in the namelist.input file.