-
Notifications
You must be signed in to change notification settings - Fork 702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pH diagnostics for mozart_mosaic_4bin_aq chemistry option #999
Conversation
@stacywalters |
@@ -20,6 +20,12 @@ state real QC_B4MP ikj misc 1 - - "Q | |||
state real QI_B4MP ikj misc 1 - - "QI_B4MP" "CLOUD ICE BEFORE MICROPHYSICS" "kg kg-1" | |||
state real QS_B4MP ikj misc 1 - - "QS_B4MP" "SNOW BEFORE MICROPHYSICS" "kg kg-1" | |||
|
|||
state real ph_cw ikj misc 1 - - "ph_cw" "pH of cloud water" "unitless" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stacy,
If these diagnostics are only to be activated when a specific namelist option is selected, these should all be in a package.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ravanah @kayeekayee
If this is indeed an optional diagnostic, then the namelist option that activates the pH for Mozart should be used for a package for the ph_cw, ph_aer01 through 04.
@@ -135,6 +135,7 @@ subroutine mosaic_aerchem_driver( & | |||
id, curr_secs, ktau, dtstep, ktauc, dtstepc, config_flags, & | |||
t_phy, rho_phy, p_phy, & | |||
moist, chem, vbs_nbin, & | |||
ph_aer01, ph_aer02, ph_aer03, ph_aer04, & |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stacy,
Line these up
@stacywalters
|
@stacywalters |
Dave,
Thanks for handling this. I'm trying to reach Mary regarding your
suggestion to
wrap the ph diagnostics in a package. It should not be difficult. But I
need
Mary's take on it.
Stacy
…On Thu, Oct 24, 2019 at 3:52 PM Dave Gill ***@***.***> wrote:
@stacywalters <https://github.com/stacywalters>
Stacy,
I have incorporated Mary's text in the PR. Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#999?email_source=notifications&email_token=ACA4BEVGCBUKSAMQKTJD6IDQQH4I7A5CNFSM4JEJTWWKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECGHMXY#issuecomment-546076255>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACA4BEVGVB4CF5QZAC2JVJDQQH4I7ANCNFSM4JEJTWWA>
.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the packaging of the arrays done as suggested by Dave?
@stacywalters - Can you package the ph_* diagnostics as suggested by the others? |
trigger jenkins
KEYWORDS: pH, cloud water, aerosols, mozart_mosaic_4bin_aq SOURCE: Mary Barth (ACOM/MMM NCAR) and Stacy Walters (formerly NCAR) DESCRIPTION OF CHANGES: Originally submitted as PR wrf-model#999, but was resubmitted due to inconsistencies Alter Registry/registry.chem to include diagnostic pH variables ph_cw, ph_aer01, ph_aer02, ph_aer03, and ph_aer04. Modify files, listed below, to calculate and set pH diagnostic variables MOZART is a gas-phase chemistry mechanism (set of reactions) in WRF-Chem Diagnostics are activated with namelist,chem option mozart_ph_diag=1 MOSAIC is one of the aerosol models in WRF-Chem that represents the size distribution of the aerosols with 4 size bins (hence "4bin") The pH is calculated for each of the 4 aerosol size bins. That is why there are 4 variables: pH_aer1, aer2, aer3, aer4. pH is a diagnostic variable and is calculated as part of the aerosol model. However what we added was the ability to write out the field to the history file. It is by default turned off as an output field, but can be "turned on" using the iofields.txt file. There is also cloud water pH (pH_CW) which is calculated as part of the cloud chemistry routine. Same thing as aerosol pH, by default it is not an output field, but can be included in history files via iofields.txt. For pretty pictures and a description of what we learned, feel free to look at the report for the ACOM lab: https://nar.ucar.edu/2019/acom/predicting-acidity-aerosols-and-cloud-water. LIST OF MODIFIED FILES: Registry/registry.chem chem/chem_driver.F chem/cloudchem_driver.F chem/module_mosaic_cloudchem.F chem/aerosol_driver.F chem/module_mosaic_driver.F chem/module_mosaic_therm.F chem/module_chem_cup.F
KEYWORDS: pH, cloud water, aerosols, mozart_mosaic_4bin_aq SOURCE: Mary Barth (ACOM/MMM NCAR) and Stacy Walters (formerly NCAR) DESCRIPTION OF CHANGES: Originally submitted as PR #999, but was resubmitted due to inconsistencies Alter Registry/registry.chem to include diagnostic pH variables ph_cw, ph_aer01, ph_aer02, ph_aer03, and ph_aer04. Modify files, listed below, to calculate and set pH diagnostic variables MOZART is a gas-phase chemistry mechanism (set of reactions) in WRF-Chem Diagnostics are activated with namelist,chem option mozart_ph_diag=1 MOSAIC is one of the aerosol models in WRF-Chem that represents the size distribution of the aerosols with 4 size bins (hence "4bin") The pH is calculated for each of the 4 aerosol size bins. That is why there are 4 variables: pH_aer1, aer2, aer3, aer4. pH is a diagnostic variable and is calculated as part of the aerosol model. However what we added was the ability to write out the field to the history file. It is by default turned off as an output field, but can be "turned on" using the iofields.txt file. There is also cloud water pH (pH_CW) which is calculated as part of the cloud chemistry routine. Same thing as aerosol pH, by default it is not an output field, but can be included in history files via iofields.txt. For pretty pictures and a description of what we learned, feel free to look at the report for the ACOM lab: https://nar.ucar.edu/2019/acom/predicting-acidity-aerosols-and-cloud-water. LIST OF MODIFIED FILES: Registry/registry.chem chem/chem_driver.F chem/cloudchem_driver.F chem/module_mosaic_cloudchem.F chem/aerosol_driver.F chem/module_mosaic_driver.F chem/module_mosaic_therm.F chem/module_chem_cup.F
KEYWORDS: pH, cloud water, aerosols, mozart_mosaic_4bin_aq SOURCE: Mary Barth (ACOM/MMM NCAR) and Stacy Walters (formerly NCAR) DESCRIPTION OF CHANGES: Originally submitted as PR wrf-model#999, but was resubmitted due to inconsistencies Alter Registry/registry.chem to include diagnostic pH variables ph_cw, ph_aer01, ph_aer02, ph_aer03, and ph_aer04. Modify files, listed below, to calculate and set pH diagnostic variables MOZART is a gas-phase chemistry mechanism (set of reactions) in WRF-Chem Diagnostics are activated with namelist,chem option mozart_ph_diag=1 MOSAIC is one of the aerosol models in WRF-Chem that represents the size distribution of the aerosols with 4 size bins (hence "4bin") The pH is calculated for each of the 4 aerosol size bins. That is why there are 4 variables: pH_aer1, aer2, aer3, aer4. pH is a diagnostic variable and is calculated as part of the aerosol model. However what we added was the ability to write out the field to the history file. It is by default turned off as an output field, but can be "turned on" using the iofields.txt file. There is also cloud water pH (pH_CW) which is calculated as part of the cloud chemistry routine. Same thing as aerosol pH, by default it is not an output field, but can be included in history files via iofields.txt. For pretty pictures and a description of what we learned, feel free to look at the report for the ACOM lab: https://nar.ucar.edu/2019/acom/predicting-acidity-aerosols-and-cloud-water. LIST OF MODIFIED FILES: Registry/registry.chem chem/chem_driver.F chem/cloudchem_driver.F chem/module_mosaic_cloudchem.F chem/aerosol_driver.F chem/module_mosaic_driver.F chem/module_mosaic_therm.F chem/module_chem_cup.F
TYPE: new feature
KEYWORDS: pH, cloud water, aerosols, mozart_mosaic_4bin_aq
SOURCE: Mary Barth (ACOM/MMM NCAR)
DESCRIPTION OF CHANGES:
ph_aer03, and ph_aer04.
MOZART is a gas-phase chemistry mechanism (set of reactions) in WRF-Chem
MOSAIC is one of the aerosol models in WRF-Chem that represents the size distribution
of the aerosols with 4 size bins (hence "4bin")
The pH is calculated for each of the 4 aerosol size bins. That is why there are 4 variables: pH_aer1,
aer2, aer3, aer4.
pH is a diagnostic variable and is calculated as part of the aerosol model. However what we added
was the ability to write out the field to the history file. It is by default turned off as an output field,
but can be "turned on" using the iofields.txt file.
There is also cloud water pH (pH_CW) which is calculated as part of the cloud chemistry routine.
Same thing as aerosol pH, by default it is not an output field, but can be included in history files
via iofields.txt.
For pretty pictures and a description of what we learned, feel free to look at the report for the
ACOM lab: https://nar.ucar.edu/2019/acom/predicting-acidity-aerosols-and-cloud-water.
Sample:
LIST OF MODIFIED FILES:
Registry/registry.chem
chem/chem_driver.F
chem/cloudchem_driver.F
chem/module_mosaic_cloudchem.F
chem/aerosol_driver.F
chem/module_mosaic_driver.F
chem/module_mosaic_therm.F
chem/module_chem_cup.F
TESTS CONDUCTED: